Hi Matt,
On Wed, 2025-10-08 at 15:59 +0200, Matthieu Baerts (NGI0) wrote:
> The call to 'continue_if' was missing: it properly marks a subtest as
> 'skipped' if the attached condition is not valid.
>
> Without that, the test is wrongly marked as passed on older kernels.
>
> Fixes: b5e2fb832f48 ("selftests: mptcp: add explicit test case for
> remove/readd")
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
This patch looks good to me.
Reviewed-by: Geliang Tang <geliang@kernel.org>
Thanks,
-Geliang
> ---
> tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
> b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> index deba21ca5a97..59983aed2591 100755
> --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> @@ -4040,7 +4040,7 @@ endpoint_tests()
>
> # remove and re-add
> if reset_with_events "delete re-add signal" &&
> - mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then
> + continue_if mptcp_lib_kallsyms_has
> "subflow_rebuild_header$"; then
> ip netns exec $ns1 sysctl -q
> net.mptcp.add_addr_timeout=0
> pm_nl_set_limits $ns1 0 3
> pm_nl_set_limits $ns2 3 3
>