Hi Matt,
On Wed, 2025-10-08 at 15:59 +0200, Matthieu Baerts (NGI0) wrote:
> The call to 'continue_if' was missing: it properly marks a subtest as
> 'skipped' if the attached condition is not valid.
>
> Without that, the test is wrongly marked as passed on older kernels.
>
> Fixes: e06959e9eebd ("selftests: mptcp: join: test for flush/re-add
> endpoints")
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
This patch looks good to me.
Reviewed-by: Geliang Tang <geliang@kernel.org>
Thanks,
-Geliang
> ---
> tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
> b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> index c90d8e8b95cb..deba21ca5a97 100755
> --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> @@ -4115,7 +4115,7 @@ endpoint_tests()
>
> # flush and re-add
> if reset_with_tcp_filter "flush re-add" ns2 10.0.3.2 REJECT
> OUTPUT &&
> - mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then
> + continue_if mptcp_lib_kallsyms_has
> "subflow_rebuild_header$"; then
> pm_nl_set_limits $ns1 0 2
> pm_nl_set_limits $ns2 1 2
> # broadcast IP: no packet for this address will be
> received on ns1
>