Hi Matt,
Thanks for this v2.
On Fri, 2025-09-19 at 11:08 +0200, Matthieu Baerts (NGI0) wrote:
> I'm currently looking at adding ADD-ADDR endpoint type, see [1].
>
> When working on this, I decided to do something we should have done
> from
> a long time: renaming some variables with confusing names, and split
> some functions.
>
> Flushing this now, just to ease the reviews: this should be pure
> refactoring, no functional changes intended in all these commits.
>
> Based-on:
> <20250916-pm-c-flag-client-default-v2-0-3be2c5bc4d6a@kernel.org>
> Link: https://github.com/multipath-tcp/mptcp_net-next/issues/503
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Apart from a small comment in patch 1, the whole patch set looks good
to me.
Reviewed-by: Geliang Tang <geliang@kernel.org>
-Geliang
> ---
> Changes in v2:
> - patch 1: move protocol.h modif from patch 2 (Geliang)
> - patch 3: 'Reverse X-Mas Tree' order, and comments (Geliang)
> - patches 4 & 7: avoid one line above 80 chars
> - Link to v1:
> https://lore.kernel.org/r/20250918-pm-kern-endp-add_addr-v1-0-e12e58770a11@kernel.org
>
> ---
> Matthieu Baerts (NGI0) (10):
> Squash to "mptcp: pm: in-kernel: usable client side with C-
> flag"
> mptcp: pm: in-kernel: refactor fill_local_addresses_vec
> mptcp: pm: in-kernel: refactor fill_remote_addresses_vec
> mptcp: pm: rename 'subflows' to 'extra_subflows'
> mptcp: pm: in-kernel: rename 'subflows_max' to
> 'limit_extra_subflows'
> mptcp: pm: in-kernel: rename 'add_addr_signal_max' to
> 'endp_signal_max'
> mptcp: pm: in-kernel: rename 'add_addr_accept_max' to
> 'limit_add_addr_accepted'
> mptcp: pm: in-kernel: rename 'local_addr_max' to
> 'endp_subflow_max'
> mptcp: pm: in-kernel: rename 'local_addr_list' to 'endp_list'
> mptcp: pm: in-kernel: rename 'addrs' to 'endpoints'
>
> include/uapi/linux/mptcp.h | 5 +
> net/mptcp/pm.c | 17 +-
> net/mptcp/pm_kernel.c | 458
> ++++++++++++----------
> net/mptcp/pm_userspace.c | 2 +-
> net/mptcp/protocol.h | 15 +-
> net/mptcp/sockopt.c | 20 +-
> tools/testing/selftests/bpf/progs/mptcp_subflow.c | 2 +-
> 7 files changed, 292 insertions(+), 227 deletions(-)
> ---
> base-commit: 32778f6dc930afb30f995997c12cd8b829ac1600
> change-id: 20250916-pm-kern-endp-add_addr-95cfceaef3fc
>
> Best regards,