The recent patch "mptcp: make ADD_ADDR retransmission timeout adaptive"
seems causing some unstable tests, see the links below.

The modification in the selftest is reverted, and more tolerance is
added instead.

While at it, slow down some signalling tests.

Link: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/17391054770
Link: https://netdev-3.bots.linux.dev/vmksft-mptcp-dbg/results/280241/1-mptcp-join-sh/stdout
Link: https://netdev-3.bots.linux.dev/vmksft-mptcp-dbg/results/279881/1-mptcp-join-sh/stdout
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Changes in v2:
- Patch 2: tolerate more ADD_ADDR, except if no ADD_ADDR are expected.
- Add Geliang's RvB tags (thanks!)
- Link to v1: https://lore.kernel.org/r/20250902-sft-mptcp-join-add_addr-no-retrans-v1-0-956a315d6a5a@kernel.org

---
Matthieu Baerts (NGI0) (3):
      Squash to "selftests: mptcp: remove add_addr_timeout settings"
      selftests: mptcp: join: tolerate more ADD_ADDR
      selftests: mptcp: join: allow more time to send ADD_ADDR

 tools/testing/selftests/net/mptcp/mptcp_join.sh | 28 ++++++++++++-------------
 1 file changed, 14 insertions(+), 14 deletions(-)
---
base-commit: 8984ec428a58d1d82ba89db40e462ad1e8dd317e
change-id: 20250902-sft-mptcp-join-add_addr-no-retrans-345b5db46fac

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>

Hi Geliang,

On 04/09/2025 13:38, Matthieu Baerts (NGI0) wrote:
> The recent patch "mptcp: make ADD_ADDR retransmission timeout adaptive"
> seems causing some unstable tests, see the links below.
> 
> The modification in the selftest is reverted, and more tolerance is
> added instead.
> 
> While at it, slow down some signalling tests.

Thank you for the review!

Now in our tree, with the suggested fix:

New patches for t/upstream:
- a37ad3e9fe07: "squashed" patch 1/3 in "selftests: mptcp: remove
add_addr_timeout settings"
- 97cd737c96db: selftests: mptcp: join: tolerate more ADD_ADDR
- 1782e66db572: selftests: mptcp: join: allow more time to send ADD_ADDR
- Results: b908f5af710b..9335a0684b09 (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/f109be59e49a8e13d97704bde7c726ff26835034/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Hi Matthieu,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Unstable: 1 failed test(s): selftest_mptcp_connect 🔴
- KVM Validation: debug: Unstable: 3 failed test(s): packetdrill_add_addr selftest_mptcp_connect_checksum selftest_mptcp_join 🔴
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/17463051487

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/7003d852301a
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=998827


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)