A flush of the MPTCP endpoints should not affect the MPTCP limits. In
other words, 'ip mptcp endpoint flush' should not change 'ip mptcp
limits'.

But it was the case. Patch 1 fixes the issue, and Patch 2 modified
pm_netlink.sh selftest to validate the modification on the kernel side.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Matthieu Baerts (NGI0) (2):
      mptcp: pm: kernel: flush: do not reset ADD_ADDR limit
      selftests: mptcp: pm: check flush doesn't reset limits

 net/mptcp/pm_kernel.c                           | 1 -
 tools/testing/selftests/net/mptcp/pm_netlink.sh | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)
---
base-commit: 8353c34f924e5fb87e86e5587e15df160add9a44
change-id: 20250806-mptcp-pm-flush-limit-c5a2d74fc2ea

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>

On Wed, 6 Aug 2025, Matthieu Baerts (NGI0) wrote:

> A flush of the MPTCP endpoints should not affect the MPTCP limits. In
> other words, 'ip mptcp endpoint flush' should not change 'ip mptcp
> limits'.
>
> But it was the case. Patch 1 fixes the issue, and Patch 2 modified
> pm_netlink.sh selftest to validate the modification on the kernel side.
>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
> Matthieu Baerts (NGI0) (2):
>      mptcp: pm: kernel: flush: do not reset ADD_ADDR limit
>      selftests: mptcp: pm: check flush doesn't reset limits
>
> net/mptcp/pm_kernel.c                           | 1 -
> tools/testing/selftests/net/mptcp/pm_netlink.sh | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
> ---
> base-commit: 8353c34f924e5fb87e86e5587e15df160add9a44
> change-id: 20250806-mptcp-pm-flush-limit-c5a2d74fc2ea
>

Series LGTM, thanks Matthieu!

Reviewed-by: Mat Martineau <martineau@kernel.org>

Hi Mat,

On 14/08/2025 02:25, Mat Martineau wrote:
> On Wed, 6 Aug 2025, Matthieu Baerts (NGI0) wrote:
> 
>> A flush of the MPTCP endpoints should not affect the MPTCP limits. In
>> other words, 'ip mptcp endpoint flush' should not change 'ip mptcp
>> limits'.
>>
>> But it was the case. Patch 1 fixes the issue, and Patch 2 modified
>> pm_netlink.sh selftest to validate the modification on the kernel side.
>>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>> ---
>> Matthieu Baerts (NGI0) (2):
>>      mptcp: pm: kernel: flush: do not reset ADD_ADDR limit
>>      selftests: mptcp: pm: check flush doesn't reset limits
>>
>> net/mptcp/pm_kernel.c                           | 1 -
>> tools/testing/selftests/net/mptcp/pm_netlink.sh | 1 +
>> 2 files changed, 1 insertion(+), 1 deletion(-)
>> ---
>> base-commit: 8353c34f924e5fb87e86e5587e15df160add9a44
>> change-id: 20250806-mptcp-pm-flush-limit-c5a2d74fc2ea
>>
> 
> Series LGTM, thanks Matthieu!
> 
> Reviewed-by: Mat Martineau <martineau@kernel.org>

Thank you for the review!

Now in our tree (fixes for -net):

New patches for t/upstream-net and t/upstream:
- 7f177b98bfef: mptcp: pm: kernel: flush: do not reset ADD_ADDR limit
- d62e61868bae: selftests: mptcp: pm: check flush doesn't reset limits
- Results: e81a6d054101..3f23a1fbaa6a (export-net)
- Results: 6e5604790ba7..7c14230bb733 (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/af6558fbffb5f4001db78a0b124920bc4555ae7a/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/0e9edf26da4f62d2781a9cdca55e6e6af18d5c0e/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Hi Matthieu,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Unstable: 1 failed test(s): selftest_mptcp_connect 🔴
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/16780011899

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/e165b9888212
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=988782


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)