Fixes for "selftests: mptcp: connect: cover alt modes"

[PATCH mptcp-net 0/2] Fixes for "selftests: mptcp: connect: cover alt modes"

Posted by Matthieu Baerts (NGI0) 2 months ago

Without that, all mptcp_connect*.sh subtests have the same name, e.g.

  mptcp_connect: ping tests  ## from mptcp_connect.sh
  mptcp_connect: ping tests  ## from mptcp_connect_checksum.sh
  mptcp_connect: ping tests  ## from mptcp_connect_mmap.sh
  mptcp_connect: ping tests  ## from mptcp_connect_sendfile.sh

In such case, the CI will only see one subtest, not 4 different ones.

To fix that, MPTCP_LIB_KSFT_TEST env var can simply be set.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Matthieu Baerts (NGI0) (2):
      Squash to "selftests: mptcp: connect: also cover alt modes"
      Squash to "selftests: mptcp: connect: also cover checksum"

 tools/testing/selftests/net/mptcp/mptcp_connect_checksum.sh | 3 ++-
 tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh     | 3 ++-
 tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)
---
base-commit: 422cf93634436650f6ea5dacb37f1edfed7ab3c9
change-id: 20250715-selftests-mptcp-connect-modes-fixes-61383574b42a

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>

Re: [PATCH mptcp-net 0/2] Fixes for "selftests: mptcp: connect: cover alt modes"

Posted by Geliang Tang 2 months ago

Hi Matt,

On Tue, 2025-07-15 at 11:49 +0200, Matthieu Baerts (NGI0) wrote:
> Without that, all mptcp_connect*.sh subtests have the same name, e.g.
> 
>   mptcp_connect: ping tests  ## from mptcp_connect.sh
>   mptcp_connect: ping tests  ## from mptcp_connect_checksum.sh
>   mptcp_connect: ping tests  ## from mptcp_connect_mmap.sh
>   mptcp_connect: ping tests  ## from mptcp_connect_sendfile.sh
> 
> In such case, the CI will only see one subtest, not 4 different ones.
> 
> To fix that, MPTCP_LIB_KSFT_TEST env var can simply be set.
> 
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

LGTM!

Reviewed-by: Geliang Tang <geliang@kernel.org>

Thanks,
-Geliang

> ---
> Matthieu Baerts (NGI0) (2):
>       Squash to "selftests: mptcp: connect: also cover alt modes"
>       Squash to "selftests: mptcp: connect: also cover checksum"
> 
>  tools/testing/selftests/net/mptcp/mptcp_connect_checksum.sh | 3 ++-
>  tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh     | 3 ++-
>  tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh | 3 ++-
>  3 files changed, 6 insertions(+), 3 deletions(-)
> ---
> base-commit: 422cf93634436650f6ea5dacb37f1edfed7ab3c9
> change-id: 20250715-selftests-mptcp-connect-modes-fixes-61383574b42a
> 
> Best regards,

Re: [PATCH mptcp-net 0/2] Fixes for "selftests: mptcp: connect: cover alt modes"

Posted by Matthieu Baerts 2 months ago

Hi Geliang,

On 15/07/2025 11:52, Geliang Tang wrote:
> Hi Matt,
> 
> On Tue, 2025-07-15 at 11:49 +0200, Matthieu Baerts (NGI0) wrote:
>> Without that, all mptcp_connect*.sh subtests have the same name, e.g.
>>
>>   mptcp_connect: ping tests  ## from mptcp_connect.sh
>>   mptcp_connect: ping tests  ## from mptcp_connect_checksum.sh
>>   mptcp_connect: ping tests  ## from mptcp_connect_mmap.sh
>>   mptcp_connect: ping tests  ## from mptcp_connect_sendfile.sh
>>
>> In such case, the CI will only see one subtest, not 4 different ones.
>>
>> To fix that, MPTCP_LIB_KSFT_TEST env var can simply be set.
>>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
> LGTM!
> 
> Reviewed-by: Geliang Tang <geliang@kernel.org>

Thank you for the quick review!

Now in our tree:

New patches for t/upstream-net and t/upstream:
- b3ad2903fba4: "squashed" patch 1/2 in "selftests: mptcp: connect: also
cover alt modes"
- 66d7601242b5: "squashed" patch 2/2 in "selftests: mptcp: connect: also
cover checksum"
- Results: c38c723b6c8e..dc8fe14f5e8b (export-net)
- Results: 422cf9363443..a5f1eec0881b (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/d202fc514d0d69e212781052c8ca20c6990f11f3/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/8a2039d246ee0028762f2304f8878e433afab20d/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.