A new binary is now generated by the MPTCP selftests: mptcp_diag.

Like the other binaries from this directory, there is no need to track
this in Git, it should then be ignored.

Fixes: 00f5e338cf7e ("selftests: mptcp: Add a tool to get specific msk_info")
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
 tools/testing/selftests/net/mptcp/.gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/mptcp/.gitignore b/tools/testing/selftests/net/mptcp/.gitignore
index 49daae73c41e6f86c6f0e47aa42426e5ad5c17e6..833279fb34e2dd74a27f16c26e44108029dd45e1 100644
--- a/tools/testing/selftests/net/mptcp/.gitignore
+++ b/tools/testing/selftests/net/mptcp/.gitignore
@@ -1,5 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
 mptcp_connect
+mptcp_diag
 mptcp_inq
 mptcp_sockopt
 pm_nl_ctl

---
base-commit: 098b800967a7a5aa1a5d80f934893dc95784f1d8
change-id: 20250317-mptcp-sft-diag-ignore-bb66d21eb585

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>

On Mon, 17 Mar 2025, Matthieu Baerts (NGI0) wrote:

> A new binary is now generated by the MPTCP selftests: mptcp_diag.
>
> Like the other binaries from this directory, there is no need to track
> this in Git, it should then be ignored.
>
> Fixes: 00f5e338cf7e ("selftests: mptcp: Add a tool to get specific msk_info")
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

LGTM:

Reviewed-by: Mat Martineau <martineau@kernel.org>

> ---
> tools/testing/selftests/net/mptcp/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/net/mptcp/.gitignore b/tools/testing/selftests/net/mptcp/.gitignore
> index 49daae73c41e6f86c6f0e47aa42426e5ad5c17e6..833279fb34e2dd74a27f16c26e44108029dd45e1 100644
> --- a/tools/testing/selftests/net/mptcp/.gitignore
> +++ b/tools/testing/selftests/net/mptcp/.gitignore
> @@ -1,5 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0-only
> mptcp_connect
> +mptcp_diag
> mptcp_inq
> mptcp_sockopt
> pm_nl_ctl
>
> ---
> base-commit: 098b800967a7a5aa1a5d80f934893dc95784f1d8
> change-id: 20250317-mptcp-sft-diag-ignore-bb66d21eb585
>
> Best regards,
> -- 
> Matthieu Baerts (NGI0) <matttbe@kernel.org>
>
>
>

Hi Mat,

On 18/03/2025 02:17, Mat Martineau wrote:
> On Mon, 17 Mar 2025, Matthieu Baerts (NGI0) wrote:
> 
>> A new binary is now generated by the MPTCP selftests: mptcp_diag.
>>
>> Like the other binaries from this directory, there is no need to track
>> this in Git, it should then be ignored.
>>
>> Fixes: 00f5e338cf7e ("selftests: mptcp: Add a tool to get specific
>> msk_info")
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
> LGTM:
> 
> Reviewed-by: Mat Martineau <martineau@kernel.org>

Thank you!

Now in our tree:

New patches for t/upstream:
- 67fefa933291: selftests: mptcp: ignore mptcp_diag binary
- Results: 8b41d802004a..8131e8aff41d (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/c82c9438b7e32f95e7e5c10851b9b49128f043a6/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Hi Matthieu,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Unstable: 1 failed test(s): bpftest_test_progs-no_alu32_mptcp 🔴
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/13905653117

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/1a75ef49f70a
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=944785


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)