mptcp: sockopt: fix missing get options

[PATCH mptcp-net 0/2] mptcp: sockopt: fix missing get options

Posted by Matthieu Baerts (NGI0) 1 month ago

When adding a socket option support in MPTCP, both the get and set parts
are supposed to be implemented.

A few socket options had the 'set' part implemented, but not the 'get'
part, while everything was in place to expose it, just the last step was
missing. It looks like this was not intentional, and the 'get' support
should have been present from the beginning, hence the 'Fixes' tags.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Matthieu Baerts (NGI0) (2):
      mptcp: sockopt: fix getting IPV6_V6ONLY
      mptcp: sockopt: fix getting freebind & transparent

 net/mptcp/sockopt.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)
---
base-commit: b084c48057bbf45fbedc06d7a9d4ec417992fb1e
change-id: 20250303-mptcp-sockopt-missing-get-356e26dc6955

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>

Re: [PATCH mptcp-net 0/2] mptcp: sockopt: fix missing get options

Posted by Mat Martineau 1 month ago

On Tue, 4 Mar 2025, Matthieu Baerts (NGI0) wrote:

> When adding a socket option support in MPTCP, both the get and set parts
> are supposed to be implemented.
>
> A few socket options had the 'set' part implemented, but not the 'get'
> part, while everything was in place to expose it, just the last step was
> missing. It looks like this was not intentional, and the 'get' support
> should have been present from the beginning, hence the 'Fixes' tags.
>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
> Matthieu Baerts (NGI0) (2):
>      mptcp: sockopt: fix getting IPV6_V6ONLY
>      mptcp: sockopt: fix getting freebind & transparent
>
> net/mptcp/sockopt.c | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
> ---
> base-commit: b084c48057bbf45fbedc06d7a9d4ec417992fb1e
> change-id: 20250303-mptcp-sockopt-missing-get-356e26dc6955

Hi Matthieu -

The series looks good to me:

Reviewed-by: Mat Martineau <martineau@kernel.org>

Re: [PATCH mptcp-net 0/2] mptcp: sockopt: fix missing get options

Posted by Matthieu Baerts 4 weeks, 1 day ago

Hi Mat,

On 05/03/2025 02:42, Mat Martineau wrote:
> On Tue, 4 Mar 2025, Matthieu Baerts (NGI0) wrote:
> 
>> When adding a socket option support in MPTCP, both the get and set parts
>> are supposed to be implemented.
>>
>> A few socket options had the 'set' part implemented, but not the 'get'
>> part, while everything was in place to expose it, just the last step was
>> missing. It looks like this was not intentional, and the 'get' support
>> should have been present from the beginning, hence the 'Fixes' tags.
>>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>> ---
>> Matthieu Baerts (NGI0) (2):
>>      mptcp: sockopt: fix getting IPV6_V6ONLY
>>      mptcp: sockopt: fix getting freebind & transparent
>>
>> net/mptcp/sockopt.c | 28 ++++++++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>> ---
>> base-commit: b084c48057bbf45fbedc06d7a9d4ec417992fb1e
>> change-id: 20250303-mptcp-sockopt-missing-get-356e26dc6955
> 
> Hi Matthieu -
> 
> The series looks good to me:
> 
> Reviewed-by: Mat Martineau <martineau@kernel.org>

Thank you for the review!

Now in our tree (fixes for -net):

New patches for t/upstream-net and t/upstream:
- f5b862898d83: mptcp: sockopt: fix getting IPV6_V6ONLY
- 7e0ad93236c1: mptcp: sockopt: fix getting freebind & transparent
- Results: 74ce8fb51c46..f1d6b77be72d (export-net)
- Results: 0a1c12618a04..318c86579343 (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/585fa1467b894289fe3c3ad009b203d1de00ad9a/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/4a4388014f7c410b33a39aac85c1ca6fe1b4907d/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.