[PATCH net-next] mptcp: Remove unused declaration mptcp_set_owner_r()

Yue Haibing posted 1 patch 1 month, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20250228095148.4003065-1-yuehaibing@huawei.com
net/mptcp/protocol.h | 1 -
1 file changed, 1 deletion(-)
[PATCH net-next] mptcp: Remove unused declaration mptcp_set_owner_r()
Posted by Yue Haibing 1 month, 1 week ago
Commit 6639498ed85f ("mptcp: cleanup mem accounting")
removed the implementation but leave declaration.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 net/mptcp/protocol.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
index 256677c43ca6..bd2992776d8a 100644
--- a/net/mptcp/protocol.h
+++ b/net/mptcp/protocol.h
@@ -720,7 +720,6 @@ struct sock *__mptcp_nmpc_sk(struct mptcp_sock *msk);
 bool __mptcp_close(struct sock *sk, long timeout);
 void mptcp_cancel_work(struct sock *sk);
 void __mptcp_unaccepted_force_close(struct sock *sk);
-void mptcp_set_owner_r(struct sk_buff *skb, struct sock *sk);
 void mptcp_set_state(struct sock *sk, int state);
 
 bool mptcp_addresses_equal(const struct mptcp_addr_info *a,
-- 
2.34.1
Re: [PATCH net-next] mptcp: Remove unused declaration mptcp_set_owner_r()
Posted by Matthieu Baerts 1 month, 1 week ago
Hi Yue,

On 28/02/2025 10:51, Yue Haibing wrote:
> Commit 6639498ed85f ("mptcp: cleanup mem accounting")
> removed the implementation but leave declaration.

Thank you, it looks good to me.

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

@Netdev maintainers: it can be applied in net-next directly.
Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.
Re: [PATCH net-next] mptcp: Remove unused declaration mptcp_set_owner_r()
Posted by MPTCP CI 1 month, 1 week ago
Hi Yue,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/13585649743

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/077f8a1c5011
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=938898


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)