| ... | ... | ||
|---|---|---|---|
| 11 | unnoticed because the test is currently ignored. The recent modification | 11 | unnoticed because the test is currently ignored. The recent modification |
| 12 | only shown an existing issue: xdisconnect() doesn't need to be used | 12 | only shown an existing issue: xdisconnect() doesn't need to be used |
| 13 | here, only the shutdown() part is needed. | 13 | here, only the shutdown() part is needed. |
| 14 | 14 | ||
| 15 | Fixes: 6bf41020b72b ("selftests: mptcp: update and extend fastclose test-cases") | 15 | Fixes: 6bf41020b72b ("selftests: mptcp: update and extend fastclose test-cases") |
| 16 | Cc: stable@vger.kernel.org | ||
| 17 | Reviewed-by: Mat Martineau <martineau@kernel.org> | ||
| 16 | Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> | 18 | Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> |
| 17 | --- | 19 | --- |
| 18 | Notes: | 20 | Notes: |
| 19 | - With the modification, the mptcp_join's "fastclose test" is still a | 21 | - The failure was not clearly visible on NIPA, because the results for |
| 20 | bit unstable on my side with a debug kernel. I didn't try to fix that. | 22 | the two impacted sub-tests are currently ignored (unstable). Still, |
| 21 | This is tracked by this (old) issue: | 23 | it looks important to fix that, as this will help when the tests will |
| 22 | https://github.com/multipath-tcp/mptcp_net-next/issues/324 | 24 | be improved not to be unstable any more. |
| 23 | --- | 25 | --- |
| 24 | tools/testing/selftests/net/mptcp/mptcp_connect.c | 2 +- | 26 | tools/testing/selftests/net/mptcp/mptcp_connect.c | 2 +- |
| 25 | 1 file changed, 1 insertion(+), 1 deletion(-) | 27 | 1 file changed, 1 insertion(+), 1 deletion(-) |
| 26 | 28 | ||
| 27 | diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.c b/tools/testing/selftests/net/mptcp/mptcp_connect.c | 29 | diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.c b/tools/testing/selftests/net/mptcp/mptcp_connect.c |
| ... | ... | ||
| 37 | } else if (--cfg_repeat > 0) { | 39 | } else if (--cfg_repeat > 0) { |
| 38 | xdisconnect(fd); | 40 | xdisconnect(fd); |
| 39 | 41 | ||
| 40 | 42 | ||
| 41 | --- | 43 | --- |
| 42 | base-commit: ef015705ac0b0da25ea399d87f1fa2f545b2b3d5 | 44 | base-commit: 4241a702e0d0c2ca9364cfac08dbf134264962de |
| 43 | change-id: 20250127-selftests-mptcp-fastclose-tests-af1fdd965826 | 45 | change-id: 20250204-net-mptcp-sft-conn-f-d1c14274ba66 |
| 44 | 46 | ||
| 45 | Best regards, | 47 | Best regards, |
| 46 | -- | 48 | -- |
| 47 | Matthieu Baerts (NGI0) <matttbe@kernel.org> | 49 | Matthieu Baerts (NGI0) <matttbe@kernel.org> | diff view generated by jsdifflib |