selftests: mptcp: more info in case of errors

[PATCH mptcp-next 0/5] selftests: mptcp: more info in case of errors

Matthieu Baerts (NGI0) posted 5 patches 1 week, 5 days ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20250108-slft-mptcp-conn-misc-impr-v1-0-bdfbdba48a1f@kernel.org

tools/testing/selftests/net/mptcp/mptcp_connect.sh | 13 ++++---------
tools/testing/selftests/net/mptcp/mptcp_join.sh    |  9 ++-------
tools/testing/selftests/net/mptcp/mptcp_lib.sh     | 21 +++++++++++++++++++++
tools/testing/selftests/net/mptcp/mptcp_sockopt.sh |  6 +-----
tools/testing/selftests/net/mptcp/simult_flows.sh  | 21 ++++++++++++++-------
5 files changed, 42 insertions(+), 28 deletions(-)

Expand all Fold all

[PATCH mptcp-next 0/5] selftests: mptcp: more info in case of errors

Posted by Matthieu Baerts (NGI0) 1 week, 5 days ago

Here are just a bunch of small improvements:

- MIB and 'ss -Me' in simult_flows.sh
- move common code to lib.sh
- use 'ss' with '-m'
- remove unused variable
- show only the size instead of size + filename

Nothing exiting, but the 3rd one can help investigating some issues like
https://github.com/multipath-tcp/mptcp_net-next/issues/499

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Matthieu Baerts (NGI0) (5):
      selftests: mptcp: simult_flows: unify errors msgs
      selftests: mptcp: move stats info in case of errors to lib.sh
      selftests: mptcp: add -m with ss in case of errors
      selftests: mptcp: connect: remove unused variable
      selftests: mptcp: connect: better display the files size

 tools/testing/selftests/net/mptcp/mptcp_connect.sh | 13 ++++---------
 tools/testing/selftests/net/mptcp/mptcp_join.sh    |  9 ++-------
 tools/testing/selftests/net/mptcp/mptcp_lib.sh     | 21 +++++++++++++++++++++
 tools/testing/selftests/net/mptcp/mptcp_sockopt.sh |  6 +-----
 tools/testing/selftests/net/mptcp/simult_flows.sh  | 21 ++++++++++++++-------
 5 files changed, 42 insertions(+), 28 deletions(-)
---
base-commit: f289bc80702ce603593169e80f339e9ffc48cafc
change-id: 20250108-slft-mptcp-conn-misc-impr-0cc5537a8bf2

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>

Re: [PATCH mptcp-next 0/5] selftests: mptcp: more info in case of errors

Posted by Matthieu Baerts 1 week, 2 days ago

Hi Geliang,

On 08/01/2025 19:40, Matthieu Baerts (NGI0) wrote:
> Here are just a bunch of small improvements:
> 
> - MIB and 'ss -Me' in simult_flows.sh
> - move common code to lib.sh
> - use 'ss' with '-m'
> - remove unused variable
> - show only the size instead of size + filename
> 
> Nothing exiting, but the 3rd one can help investigating some issues like
> https://github.com/multipath-tcp/mptcp_net-next/issues/499

Now in our tree (feat. for net-next) with Geliang's RvB tag (I hope
that's OK),

New patches for t/upstream:
- 5731da7ccbbf: selftests: mptcp: simult_flows: unify errors msgs
- 668a6c97c2b1: selftests: mptcp: sockopt: save nstat infos
- 1cb853be929c: selftests: mptcp: move stats info in case of errors to
lib.sh
- a97277439285: selftests: mptcp: add -m with ss in case of errors
- 70019b947cf7: selftests: mptcp: connect: remove unused variable
- c94beebdce72: selftests: mptcp: connect: better display the files size
- Results: 17aabfa75062..632bb7330ffe (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/3d444e3a3d41f6228c9bcdc5dbf649cc6857c7d3/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.