[v2] netlink: specs: mptcp: events: missing and clearer attr

[PATCH mptcp-net v2 0/3] netlink: specs: mptcp: events: missing and clearer attr

Posted by Matthieu Baerts (NGI0) 5 days, 5 hours ago

Three small fixes for the documentation:

- The 'server-side' attribute was missing for two events

- Attributes were written at the beginning, but without explaining what
  they were.

- Replace two "todo".

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Changes in v2:
- Patch 2: shorter prefix: "Attributes:" instead of "The defined
  attributes are"
- Patch 3: new patch
- Link to v1: https://lore.kernel.org/r/20241213-mptcp-pm-nl-spec-doc-attr-v1-0-e43165c94e81@kernel.org

---
Matthieu Baerts (NGI0) (3):
      netlink: specs: mptcp: add missing 'server-side' attr
      netlink: specs: mptcp: clearly mention attributes
      netlink: specs: mptcp: fix missing doc

 Documentation/netlink/specs/mptcp_pm.yaml | 52 ++++++++++++++++---------------
 1 file changed, 27 insertions(+), 25 deletions(-)
---
base-commit: abd143d0ceebde7465127242f5eeef1e9ea4e253
change-id: 20241213-mptcp-pm-nl-spec-doc-attr-663cc79843cf

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>

Re: [PATCH mptcp-net v2 0/3] netlink: specs: mptcp: events: missing and clearer attr

Posted by Geliang Tang 3 days, 15 hours ago

On Mon, 2024-12-16 at 11:39 +0100, Matthieu Baerts (NGI0) wrote:
> Three small fixes for the documentation:
> 
> - The 'server-side' attribute was missing for two events
> 
> - Attributes were written at the beginning, but without explaining
> what
>   they were.
> 
> - Replace two "todo".
> 
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
> Changes in v2:
> - Patch 2: shorter prefix: "Attributes:" instead of "The defined
>   attributes are"
> - Patch 3: new patch
> - Link to v1:
> https://lore.kernel.org/r/20241213-mptcp-pm-nl-spec-doc-attr-v1-0-e43165c94e81@kernel.org
> 
> ---
> Matthieu Baerts (NGI0) (3):
>       netlink: specs: mptcp: add missing 'server-side' attr
>       netlink: specs: mptcp: clearly mention attributes
>       netlink: specs: mptcp: fix missing doc

Thanks Matt, this set looks good to me. Please update patch 3 when
applying it.

    Reviewed-by: Geliang Tang <geliang@kernel.org>

-Geliang

> 
>  Documentation/netlink/specs/mptcp_pm.yaml | 52 ++++++++++++++++-----
> ----------
>  1 file changed, 27 insertions(+), 25 deletions(-)
> ---
> base-commit: abd143d0ceebde7465127242f5eeef1e9ea4e253
> change-id: 20241213-mptcp-pm-nl-spec-doc-attr-663cc79843cf
> 
> Best regards,

Re: [PATCH mptcp-net v2 0/3] netlink: specs: mptcp: events: missing and clearer attr

Posted by Matthieu Baerts 2 days, 22 hours ago

Hi Geliang,

On 18/12/2024 02:11, Geliang Tang wrote:
> On Mon, 2024-12-16 at 11:39 +0100, Matthieu Baerts (NGI0) wrote:
>> Three small fixes for the documentation:
>>
>> - The 'server-side' attribute was missing for two events
>>
>> - Attributes were written at the beginning, but without explaining
>> what
>>   they were.
>>
>> - Replace two "todo".
>>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>> ---
>> Changes in v2:
>> - Patch 2: shorter prefix: "Attributes:" instead of "The defined
>>   attributes are"
>> - Patch 3: new patch
>> - Link to v1:
>> https://lore.kernel.org/r/20241213-mptcp-pm-nl-spec-doc-attr-v1-0-e43165c94e81@kernel.org
>>
>> ---
>> Matthieu Baerts (NGI0) (3):
>>       netlink: specs: mptcp: add missing 'server-side' attr
>>       netlink: specs: mptcp: clearly mention attributes
>>       netlink: specs: mptcp: fix missing doc
> 
> Thanks Matt, this set looks good to me. Please update patch 3 when
> applying it.

Thank you for the review!

Now in our tree (fixes for -net):

New patches for t/upstream-net and t/upstream:
- 56bbc372ddec: netlink: specs: mptcp: add missing 'server-side' attr
- 828504a471fb: netlink: specs: mptcp: clearly mention attributes
- 9170ddb989f2: netlink: specs: mptcp: fix missing doc
- Results: 8cbaf3b4eced..9f649acfdb71 (export-net)
- Results: 6ba1915d2a6e..c0036d5057b6 (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/09e79b2ebb69e15f50c589c9f4e167a66d1d0d6f/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/83b05b020be8a5dac7d312ef7d26015ecd549ab0/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.