[v1] netlink: specs: mptcp: events: missing and clearer attr

[PATCH mptcp-net 0/2] netlink: specs: mptcp: events: missing and clearer attr

Posted by Matthieu Baerts (NGI0) 1 week ago

Two small fixes for the documentation:

- The 'server-side' attribute was missing for two events

- Attributes were written at the beginning, but without explaining what
  they were.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Matthieu Baerts (NGI0) (2):
      netlink: specs: mptcp: add missing 'server-side' attr
      netlink: specs: mptcp: clearly mention attributes

 Documentation/netlink/specs/mptcp_pm.yaml | 29 ++++++++++++++++-------------
 1 file changed, 16 insertions(+), 13 deletions(-)
---
base-commit: abd143d0ceebde7465127242f5eeef1e9ea4e253
change-id: 20241213-mptcp-pm-nl-spec-doc-attr-663cc79843cf

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>

Re: [PATCH mptcp-net 0/2] netlink: specs: mptcp: events: missing and clearer attr

Posted by Geliang Tang 5 days, 6 hours ago

Hi Matt,

Thanks for this set.

On Fri, 2024-12-13 at 18:55 +0100, Matthieu Baerts (NGI0) wrote:
> Two small fixes for the documentation:
> 
> - The 'server-side' attribute was missing for two events
> 
> - Attributes were written at the beginning, but without explaining
> what
>   they were.
> 
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
> Matthieu Baerts (NGI0) (2):
>       netlink: specs: mptcp: add missing 'server-side' attr
>       netlink: specs: mptcp: clearly mention attributes

I think we should swap the positions of these two patches, first move
these attributes to the end, then add missing 'server-side' attribute.
WDYT?

Thanks,
-Geliang

> 
>  Documentation/netlink/specs/mptcp_pm.yaml | 29 ++++++++++++++++-----
> --------
>  1 file changed, 16 insertions(+), 13 deletions(-)
> ---
> base-commit: abd143d0ceebde7465127242f5eeef1e9ea4e253
> change-id: 20241213-mptcp-pm-nl-spec-doc-attr-663cc79843cf
> 
> Best regards,

Re: [PATCH mptcp-net 0/2] netlink: specs: mptcp: events: missing and clearer attr

Posted by Matthieu Baerts 5 days, 5 hours ago

Hi Geliang,

Thank you for the review.

On 16/12/2024 10:22, Geliang Tang wrote:
> Hi Matt,
> 
> Thanks for this set.
> 
> On Fri, 2024-12-13 at 18:55 +0100, Matthieu Baerts (NGI0) wrote:
>> Two small fixes for the documentation:
>>
>> - The 'server-side' attribute was missing for two events
>>
>> - Attributes were written at the beginning, but without explaining
>> what
>>   they were.
>>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>> ---
>> Matthieu Baerts (NGI0) (2):
>>       netlink: specs: mptcp: add missing 'server-side' attr
>>       netlink: specs: mptcp: clearly mention attributes
> 
> I think we should swap the positions of these two patches, first move
> these attributes to the end, then add missing 'server-side' attribute.
> WDYT?

It would make sense if these patches were for net-next, but for fixes
modifying the same area, I think it is better to order them by commits
they fix.

The first one is for 5.19, and the second one is for 6.7. Of course,
here, there will be conflicts for the first one with < 6.7 versions. But
still, better not to increase the complexity of the backports.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Re: [PATCH mptcp-net 0/2] netlink: specs: mptcp: events: missing and clearer attr

Posted by Geliang Tang 4 days, 9 hours ago

On Mon, 2024-12-16 at 11:02 +0100, Matthieu Baerts wrote:
> Hi Geliang,
> 
> Thank you for the review.
> 
> On 16/12/2024 10:22, Geliang Tang wrote:
> > Hi Matt,
> > 
> > Thanks for this set.
> > 
> > On Fri, 2024-12-13 at 18:55 +0100, Matthieu Baerts (NGI0) wrote:
> > > Two small fixes for the documentation:
> > > 
> > > - The 'server-side' attribute was missing for two events
> > > 
> > > - Attributes were written at the beginning, but without
> > > explaining
> > > what
> > >   they were.
> > > 
> > > Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> > > ---
> > > Matthieu Baerts (NGI0) (2):
> > >       netlink: specs: mptcp: add missing 'server-side' attr
> > >       netlink: specs: mptcp: clearly mention attributes
> > 
> > I think we should swap the positions of these two patches, first
> > move
> > these attributes to the end, then add missing 'server-side'
> > attribute.
> > WDYT?
> 
> It would make sense if these patches were for net-next, but for fixes
> modifying the same area, I think it is better to order them by
> commits
> they fix.
> 
> The first one is for 5.19, and the second one is for 6.7. Of course,
> here, there will be conflicts for the first one with < 6.7 versions.
> But
> still, better not to increase the complexity of the backports.

If so, this set LGTM. I'll add my reviewed-by tag for v2.

Thanks,
-Geliang

> 
> Cheers,
> Matt