Patches here add 'time=<N>ms' in the diagnostic data of the TAP output,
e.g.

  ok 1 - pm_netlink: defaults addr list # time=9ms

This addition is useful to quickly identify which subtests are taking a
longer time than the others, or more than expected.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Matthieu Baerts (NGI0) (3):
      selftests: mptcp: lib: add time per subtests in TAP output
      sefltests: mptcp: connect: remote time in TAP output
      selftests: mptcp: reset the last TS before the first test

 tools/testing/selftests/net/mptcp/mptcp_connect.sh |  3 ++-
 tools/testing/selftests/net/mptcp/mptcp_join.sh    |  3 ++-
 tools/testing/selftests/net/mptcp/mptcp_lib.sh     | 17 ++++++++++++++++-
 tools/testing/selftests/net/mptcp/mptcp_sockopt.sh |  1 +
 tools/testing/selftests/net/mptcp/pm_netlink.sh    |  2 ++
 tools/testing/selftests/net/mptcp/simult_flows.sh  |  1 +
 tools/testing/selftests/net/mptcp/userspace_pm.sh  |  1 +
 7 files changed, 25 insertions(+), 3 deletions(-)
---
base-commit: 624d90dc5dcaee846a57aa0985789623f7c64f2e
change-id: 20240821-mptcp-ksft-time-db492f4ec4da

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>

On Wed, 21 Aug 2024, Matthieu Baerts (NGI0) wrote:

> Patches here add 'time=<N>ms' in the diagnostic data of the TAP output,
> e.g.
>
>  ok 1 - pm_netlink: defaults addr list # time=9ms
>
> This addition is useful to quickly identify which subtests are taking a
> longer time than the others, or more than expected.
>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
> Matthieu Baerts (NGI0) (3):
>      selftests: mptcp: lib: add time per subtests in TAP output
>      sefltests: mptcp: connect: remote time in TAP output
>      selftests: mptcp: reset the last TS before the first test
>

Matthieu -

Series LGTM, thanks!

Reviewed-by: Mat Martineau <martineau@kernel.org>

Hi Mat,

On 24/08/2024 02:46, Mat Martineau wrote:
> On Wed, 21 Aug 2024, Matthieu Baerts (NGI0) wrote:
> 
>> Patches here add 'time=<N>ms' in the diagnostic data of the TAP output,
>> e.g.
>>
>>  ok 1 - pm_netlink: defaults addr list # time=9ms
>>
>> This addition is useful to quickly identify which subtests are taking a
>> longer time than the others, or more than expected.
>>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>> ---
>> Matthieu Baerts (NGI0) (3):
>>      selftests: mptcp: lib: add time per subtests in TAP output
>>      sefltests: mptcp: connect: remote time in TAP output
>>      selftests: mptcp: reset the last TS before the first test
>>
> 
> Matthieu -
> 
> Series LGTM, thanks!
> 
> Reviewed-by: Mat Martineau <martineau@kernel.org>

Thank you for the review!

New patches for t/upstream:
- 61eb92f67b13: selftests: mptcp: lib: add time per subtests in TAP output
- 301490f2d642: sefltests: mptcp: connect: remote time in TAP output
- 789ba8f8b57f: selftests: mptcp: reset the last TS before the first test
- Results: c94cd4e2e8ed..6b5502abeca5 (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/9038dda10acf21b8021574e26927de82080d8394/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Hi Matthieu,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/10489178247

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/e69c1c7d48b1
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=881720


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)