tcp: restrict crossed SYN specific actions to SYN-ACK

[PATCH net v2 0/2] tcp: restrict crossed SYN specific actions to SYN-ACK

Posted by Matthieu Baerts (NGI0) 3 months ago

A recent commit in TCP affects TFO and MPTCP in some cases. The first
patch fixes that.

The second one applies the same fix to another crossed SYN specific
action just before.

These two fixes simply restrict what should be done only for crossed SYN
cases to packets with SYN-ACK flags.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Changes in v2:
- Patch 1/2 has a simpler and generic check (Kuniyuki), and an updated
  comment.
- New patch 2/2: a related fix
- Link to v1: https://lore.kernel.org/r/20240716-upstream-net-next-20240716-tcp-3rd-ack-consume-sk_socket-v1-1-4e61d0b79233@kernel.org

---
Matthieu Baerts (NGI0) (2):
      tcp: process the 3rd ACK with sk_socket for TFO/MPTCP
      tcp: limit wake-up for crossed SYN cases to SYN-ACK

 net/ipv4/tcp_input.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
---
base-commit: 120f1c857a73e52132e473dee89b340440cb692b
change-id: 20240716-upstream-net-next-20240716-tcp-3rd-ack-consume-sk_socket-0cbd159fc5b0

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>

Re: [PATCH net v2 0/2] tcp: restrict crossed SYN specific actions to SYN-ACK

Posted by Paolo Abeni 2 months, 3 weeks ago

On 7/18/24 12:33, Matthieu Baerts (NGI0) wrote:
> A recent commit in TCP affects TFO and MPTCP in some cases. The first
> patch fixes that.
> 
> The second one applies the same fix to another crossed SYN specific
> action just before.
> 
> These two fixes simply restrict what should be done only for crossed SYN
> cases to packets with SYN-ACK flags.
> 
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
> Changes in v2:
> - Patch 1/2 has a simpler and generic check (Kuniyuki), and an updated
>    comment.
> - New patch 2/2: a related fix
> - Link to v1: https://lore.kernel.org/r/20240716-upstream-net-next-20240716-tcp-3rd-ack-consume-sk_socket-v1-1-4e61d0b79233@kernel.org

Re-adding Neal for awareness. It would be great if this could go through 
some packetdrill testing,

Thanks!

Paolo

Re: [PATCH net v2 0/2] tcp: restrict crossed SYN specific actions to SYN-ACK

Posted by Eric Dumazet 2 months, 3 weeks ago

On Tue, Jul 23, 2024 at 1:10 AM Paolo Abeni <pabeni@redhat.com> wrote:
>
> On 7/18/24 12:33, Matthieu Baerts (NGI0) wrote:
> > A recent commit in TCP affects TFO and MPTCP in some cases. The first
> > patch fixes that.
> >
> > The second one applies the same fix to another crossed SYN specific
> > action just before.
> >
> > These two fixes simply restrict what should be done only for crossed SYN
> > cases to packets with SYN-ACK flags.
> >
> > Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> > ---
> > Changes in v2:
> > - Patch 1/2 has a simpler and generic check (Kuniyuki), and an updated
> >    comment.
> > - New patch 2/2: a related fix
> > - Link to v1: https://lore.kernel.org/r/20240716-upstream-net-next-20240716-tcp-3rd-ack-consume-sk_socket-v1-1-4e61d0b79233@kernel.org
>
> Re-adding Neal for awareness. It would be great if this could go through
> some packetdrill testing,
>

I am back in France, let me see what I can do.