[PATCH net-next 0/6] Implement reset reason mechanism to detect

Jason Xing posted 6 patches 1 month ago
Failed in applying to current master (apply log)
There is a newer version of this series
include/net/request_sock.h |  3 +-
include/net/rstreason.h    | 93 ++++++++++++++++++++++++++++++++++++++
include/net/tcp.h          |  2 +-
include/trace/events/tcp.h | 37 +++++++++++++--
net/dccp/ipv4.c            | 10 ++--
net/dccp/ipv6.c            | 10 ++--
net/dccp/minisocks.c       |  3 +-
net/ipv4/tcp.c             | 15 ++++--
net/ipv4/tcp_ipv4.c        | 14 +++---
net/ipv4/tcp_minisocks.c   |  3 +-
net/ipv4/tcp_output.c      |  4 +-
net/ipv4/tcp_timer.c       |  9 ++--
net/ipv6/tcp_ipv6.c        | 17 ++++---
net/mptcp/protocol.c       |  4 +-
net/mptcp/subflow.c        | 33 ++++++++++----
15 files changed, 209 insertions(+), 48 deletions(-)
create mode 100644 include/net/rstreason.h
[PATCH net-next 0/6] Implement reset reason mechanism to detect
Posted by Jason Xing 1 month ago
From: Jason Xing <kernelxing@tencent.com>

In production, there are so many cases about why the RST skb is sent but
we don't have a very convenient/fast method to detect the exact underlying
reasons.

RST is implemented in two kinds: passive kind (like tcp_v4_send_reset())
and active kind (like tcp_send_active_reset()). The former can be traced
carefully 1) in TCP, with the help of drop reasons, which is based on
Eric's idea[1], 2) in MPTCP, with the help of reset options defined in
RFC 8684. The latter is relatively independent, which should be
implemented on our own.

In this series, I focus on the fundamental implement mostly about how
the rstreason mechnism and the detailed passive part works as an
example, not including the active reset part. In future, we can go
further and refine those NOT_SPECIFIED reasons.

Here are some examples when tracing:
<idle>-0       [002] ..s1.  1830.262425: tcp_send_reset: skbaddr=x
        skaddr=x src=x dest=x state=x reason=NOT_SPECIFIED
<idle>-0       [002] ..s1.  1830.262425: tcp_send_reset: skbaddr=x
        skaddr=x src=x dest=x state=x reason=NO_SOCKET

[1]
Link: https://lore.kernel.org/all/CANn89iJw8x-LqgsWOeJQQvgVg6DnL5aBRLi10QN2WBdr+X4k=w@mail.gmail.com/

Note:
It's based on top of https://patchwork.kernel.org/project/netdevbpf/list/?series=840182


Jason Xing (6):
  net: introduce rstreason to detect why the RST is sent
  rstreason: prepare for passive reset
  rstreason: prepare for active reset
  tcp: support rstreason for passive reset
  mptcp: support rstreason for passive reset
  rstreason: make it work in trace world

 include/net/request_sock.h |  3 +-
 include/net/rstreason.h    | 93 ++++++++++++++++++++++++++++++++++++++
 include/net/tcp.h          |  2 +-
 include/trace/events/tcp.h | 37 +++++++++++++--
 net/dccp/ipv4.c            | 10 ++--
 net/dccp/ipv6.c            | 10 ++--
 net/dccp/minisocks.c       |  3 +-
 net/ipv4/tcp.c             | 15 ++++--
 net/ipv4/tcp_ipv4.c        | 14 +++---
 net/ipv4/tcp_minisocks.c   |  3 +-
 net/ipv4/tcp_output.c      |  4 +-
 net/ipv4/tcp_timer.c       |  9 ++--
 net/ipv6/tcp_ipv6.c        | 17 ++++---
 net/mptcp/protocol.c       |  4 +-
 net/mptcp/subflow.c        | 33 ++++++++++----
 15 files changed, 209 insertions(+), 48 deletions(-)
 create mode 100644 include/net/rstreason.h

-- 
2.37.3
Re: [PATCH net-next 0/6] Implement reset reason mechanism to detect
Posted by Jakub Kicinski 1 month ago
On Wed,  3 Apr 2024 15:31:38 +0800 Jason Xing wrote:
> It's based on top of https://patchwork.kernel.org/project/netdevbpf/list/?series=840182

Please post as RFC if there's a dependency.
We don't maintain patch queues for people.
-- 
pw-bot: cr
Re: [PATCH net-next 0/6] Implement reset reason mechanism to detect
Posted by Jason Xing 1 month ago
On Thu, Apr 4, 2024 at 9:50 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed,  3 Apr 2024 15:31:38 +0800 Jason Xing wrote:
> > It's based on top of https://patchwork.kernel.org/project/netdevbpf/list/?series=840182
>
> Please post as RFC if there's a dependency.
> We don't maintain patch queues for people.

Got it. Thanks.

I'll wait for that patch series to get merged. I believe it will not
take too long:)

> --
> pw-bot: cr