tools/testing/selftests/net/mptcp/diag.sh | 37 ++++++++++++++--------- tools/testing/selftests/net/mptcp/mptcp_lib.sh | 21 +++++++++++++ tools/testing/selftests/net/mptcp/simult_flows.sh | 3 +- tools/testing/selftests/net/mptcp/userspace_pm.sh | 4 +-- 4 files changed, 48 insertions(+), 17 deletions(-)
It is important to have a unique (sub)test name in TAP, because some CI
environments drop tests with duplicated name.
When working on adding subtests support in Netdev's NIPA CI, I found out
some subtests had the same name. The name is used as a key, it should
then be unique, otherwise we don't track duplicated tests.
The fixes have been split in different patches, because it fixes
different commits. But the idea is always the same: make sure subtest
names are unique.
The last patch is not for -net, that's a new feature to make sure we
don't add duplicated names later.
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Matthieu Baerts (NGI0) (5):
selftests: mptcp: simult flows: fix some subtest names
selftests: mptcp: userspace_pm: unique subtest names
selftests: mptcp: diag: unique 'in use' subtest names
selftests: mptcp: diag: unique 'cestab' subtest names
selftests: mptcp: lib: catch duplicated subtest entries
tools/testing/selftests/net/mptcp/diag.sh | 37 ++++++++++++++---------
tools/testing/selftests/net/mptcp/mptcp_lib.sh | 21 +++++++++++++
tools/testing/selftests/net/mptcp/simult_flows.sh | 3 +-
tools/testing/selftests/net/mptcp/userspace_pm.sh | 4 +--
4 files changed, 48 insertions(+), 17 deletions(-)
---
base-commit: 0c8d1475f726a95cddb393e45f0b4d8ec0e15785
change-id: 20240209-selftests-mptcp-uniq-title-2e2df0c17695
Best regards,
--
Matthieu Baerts (NGI0) <matttbe@kernel.org>
On Fri, Feb 09, 2024 at 06:28:38PM +0100, Matthieu Baerts (NGI0) wrote: > It is important to have a unique (sub)test name in TAP, because some CI > environments drop tests with duplicated name. > > When working on adding subtests support in Netdev's NIPA CI, I found out > some subtests had the same name. The name is used as a key, it should > then be unique, otherwise we don't track duplicated tests. > > The fixes have been split in different patches, because it fixes > different commits. But the idea is always the same: make sure subtest > names are unique. > > The last patch is not for -net, that's a new feature to make sure we > don't add duplicated names later. > > Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> > --- > Matthieu Baerts (NGI0) (5): > selftests: mptcp: simult flows: fix some subtest names > selftests: mptcp: userspace_pm: unique subtest names > selftests: mptcp: diag: unique 'in use' subtest names > selftests: mptcp: diag: unique 'cestab' subtest names > selftests: mptcp: lib: catch duplicated subtest entries LGTM! Reviewed-by: Geliang Tang <geliang@kernel.org> Thanks, -Geliang > > tools/testing/selftests/net/mptcp/diag.sh | 37 ++++++++++++++--------- > tools/testing/selftests/net/mptcp/mptcp_lib.sh | 21 +++++++++++++ > tools/testing/selftests/net/mptcp/simult_flows.sh | 3 +- > tools/testing/selftests/net/mptcp/userspace_pm.sh | 4 +-- > 4 files changed, 48 insertions(+), 17 deletions(-) > --- > base-commit: 0c8d1475f726a95cddb393e45f0b4d8ec0e15785 > change-id: 20240209-selftests-mptcp-uniq-title-2e2df0c17695 > > Best regards, > -- > Matthieu Baerts (NGI0) <matttbe@kernel.org> >
On Fri, Feb 09, 2024 at 06:28:38PM +0100, Matthieu Baerts (NGI0) wrote: > It is important to have a unique (sub)test name in TAP, because some CI > environments drop tests with duplicated name. > > When working on adding subtests support in Netdev's NIPA CI, I found out > some subtests had the same name. The name is used as a key, it should > then be unique, otherwise we don't track duplicated tests. > > The fixes have been split in different patches, because it fixes > different commits. But the idea is always the same: make sure subtest > names are unique. > > The last patch is not for -net, that's a new feature to make sure we > don't add duplicated names later. > > Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> > --- > Matthieu Baerts (NGI0) (5): > selftests: mptcp: simult flows: fix some subtest names > selftests: mptcp: userspace_pm: unique subtest names > selftests: mptcp: diag: unique 'in use' subtest names > selftests: mptcp: diag: unique 'cestab' subtest names > selftests: mptcp: lib: catch duplicated subtest entries Hi Matt, I'd like to review this series this week. Please delegate them for me on Patchwork. I can't delegate them by myself. Thanks, -Geliang > > tools/testing/selftests/net/mptcp/diag.sh | 37 ++++++++++++++--------- > tools/testing/selftests/net/mptcp/mptcp_lib.sh | 21 +++++++++++++ > tools/testing/selftests/net/mptcp/simult_flows.sh | 3 +- > tools/testing/selftests/net/mptcp/userspace_pm.sh | 4 +-- > 4 files changed, 48 insertions(+), 17 deletions(-) > --- > base-commit: 0c8d1475f726a95cddb393e45f0b4d8ec0e15785 > change-id: 20240209-selftests-mptcp-uniq-title-2e2df0c17695 > > Best regards, > -- > Matthieu Baerts (NGI0) <matttbe@kernel.org> >
Hi Geliang, On 13/02/2024 05:21, Geliang Tang wrote: > On Fri, Feb 09, 2024 at 06:28:38PM +0100, Matthieu Baerts (NGI0) wrote: >> It is important to have a unique (sub)test name in TAP, because some CI >> environments drop tests with duplicated name. >> >> When working on adding subtests support in Netdev's NIPA CI, I found out >> some subtests had the same name. The name is used as a key, it should >> then be unique, otherwise we don't track duplicated tests. >> >> The fixes have been split in different patches, because it fixes >> different commits. But the idea is always the same: make sure subtest >> names are unique. >> >> The last patch is not for -net, that's a new feature to make sure we >> don't add duplicated names later. >> >> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> >> --- >> Matthieu Baerts (NGI0) (5): >> selftests: mptcp: simult flows: fix some subtest names >> selftests: mptcp: userspace_pm: unique subtest names >> selftests: mptcp: diag: unique 'in use' subtest names >> selftests: mptcp: diag: unique 'cestab' subtest names >> selftests: mptcp: lib: catch duplicated subtest entries > > Hi Matt, > > I'd like to review this series this week. Thank you! > Please delegate them for > me on Patchwork. I can't delegate them by myself. Sorry, I'm still not able to do that, we need to wait for kernel.org IT team to do the modification. Cheers, Matt -- Sponsored by the NGI0 Core fund.
© 2016 - 2024 Red Hat, Inc.