1. Patchew
  2. MPTCP
  3. [PATCH v2 mptcp-next 0/3] more sockopts for ephemeral ports
  4. View patch

[PATCH v2 mptcp-next 3/3] selftests/net: add MPTCP coverage for IP_LOCAL_PORT_RANGE

Maxim Galaganov posted 3 patches 2 years, 2 months ago
Maintainers: Matthieu Baerts <matttbe@kernel.org>, Mat Martineau <martineau@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>
There is a newer version of this series
[PATCH v2 mptcp-next 3/3] selftests/net: add MPTCP coverage for IP_LOCAL_PORT_RANGE
Posted by Maxim Galaganov 2 years, 2 months ago 
Since previous commit, MPTCP has support for IP_BIND_ADDRESS_NO_PORT and
IP_LOCAL_PORT_RANGE sockopts.

Add ip4_mptcp and ip6_mptcp fixture variants to ip_local_port_range
selftest to provide selftest coverage for these sockopts.

Signed-off-by: Maxim Galaganov <max@internet.ru>
---
 tools/testing/selftests/net/ip_local_port_range.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tools/testing/selftests/net/ip_local_port_range.c b/tools/testing/selftests/net/ip_local_port_range.c
index 75e3fdacdf73..0f217a1cc837 100644
--- a/tools/testing/selftests/net/ip_local_port_range.c
+++ b/tools/testing/selftests/net/ip_local_port_range.c
@@ -146,6 +146,12 @@ FIXTURE_VARIANT_ADD(ip_local_port_range, ip4_stcp) {
 	.so_protocol	= IPPROTO_SCTP,
 };
 
+FIXTURE_VARIANT_ADD(ip_local_port_range, ip4_mptcp) {
+	.so_domain	= AF_INET,
+	.so_type	= SOCK_STREAM,
+	.so_protocol	= IPPROTO_MPTCP,
+};
+
 FIXTURE_VARIANT_ADD(ip_local_port_range, ip6_tcp) {
 	.so_domain	= AF_INET6,
 	.so_type	= SOCK_STREAM,
@@ -164,6 +170,12 @@ FIXTURE_VARIANT_ADD(ip_local_port_range, ip6_stcp) {
 	.so_protocol	= IPPROTO_SCTP,
 };
 
+FIXTURE_VARIANT_ADD(ip_local_port_range, ip6_mptcp) {
+	.so_domain	= AF_INET6,
+	.so_type	= SOCK_STREAM,
+	.so_protocol	= IPPROTO_MPTCP,
+};
+
 TEST_F(ip_local_port_range, invalid_option_value)
 {
 	__u16 val16;
-- 
2.43.0
Re: [PATCH v2 mptcp-next 3/3] selftests/net: add MPTCP coverage for IP_LOCAL_PORT_RANGE
Posted by Mat Martineau 2 years, 2 months ago 
On Wed, 29 Nov 2023, Maxim Galaganov wrote:

> Since previous commit, MPTCP has support for IP_BIND_ADDRESS_NO_PORT and
> IP_LOCAL_PORT_RANGE sockopts.
>
> Add ip4_mptcp and ip6_mptcp fixture variants to ip_local_port_range
> selftest to provide selftest coverage for these sockopts.
>
> Signed-off-by: Maxim Galaganov <max@internet.ru>

Acked-by: Mat Martineau <martineau@kernel.org>

> ---
> tools/testing/selftests/net/ip_local_port_range.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/tools/testing/selftests/net/ip_local_port_range.c b/tools/testing/selftests/net/ip_local_port_range.c
> index 75e3fdacdf73..0f217a1cc837 100644
> --- a/tools/testing/selftests/net/ip_local_port_range.c
> +++ b/tools/testing/selftests/net/ip_local_port_range.c
> @@ -146,6 +146,12 @@ FIXTURE_VARIANT_ADD(ip_local_port_range, ip4_stcp) {
> 	.so_protocol	= IPPROTO_SCTP,
> };
>
> +FIXTURE_VARIANT_ADD(ip_local_port_range, ip4_mptcp) {
> +	.so_domain	= AF_INET,
> +	.so_type	= SOCK_STREAM,
> +	.so_protocol	= IPPROTO_MPTCP,
> +};
> +
> FIXTURE_VARIANT_ADD(ip_local_port_range, ip6_tcp) {
> 	.so_domain	= AF_INET6,
> 	.so_type	= SOCK_STREAM,
> @@ -164,6 +170,12 @@ FIXTURE_VARIANT_ADD(ip_local_port_range, ip6_stcp) {
> 	.so_protocol	= IPPROTO_SCTP,
> };
>
> +FIXTURE_VARIANT_ADD(ip_local_port_range, ip6_mptcp) {
> +	.so_domain	= AF_INET6,
> +	.so_type	= SOCK_STREAM,
> +	.so_protocol	= IPPROTO_MPTCP,
> +};
> +
> TEST_F(ip_local_port_range, invalid_option_value)
> {
> 	__u16 val16;
> -- 
> 2.43.0
>
>
>
Re: selftests/net: add MPTCP coverage for IP_LOCAL_PORT_RANGE: Tests Results
Posted by MPTCP CI 2 years, 2 months ago 
Hi Maxim,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join):
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/6340620462063616
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/6340620462063616/summary/summary.txt

- KVM Validation: normal (only selftest_mptcp_join):
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/4933245578510336
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/4933245578510336/summary/summary.txt

- KVM Validation: debug (except selftest_mptcp_join):
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/6059145485352960
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/6059145485352960/summary/summary.txt

- KVM Validation: debug (only selftest_mptcp_join):
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/5496195531931648
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5496195531931648/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/1963033034f8


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
Re: selftests/net: add MPTCP coverage for IP_LOCAL_PORT_RANGE: Tests Results
Posted by MPTCP CI 2 years, 2 months ago 
Hi Maxim,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- {"code":404,"message":
  - "Can't find artifacts containing file conclusion.txt"}:
  - Task: https://cirrus-ci.com/task/6232258219081728
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/6232258219081728/summary/summary.txt

- {"code":404,"message":
  - "Can't find artifacts containing file conclusion.txt"}:
  - Task: https://cirrus-ci.com/task/4824883335528448
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/4824883335528448/summary/summary.txt

- {"code":404,"message":
  - "Can't find artifacts containing file conclusion.txt"}:
  - Task: https://cirrus-ci.com/task/5950783242371072
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5950783242371072/summary/summary.txt

- {"code":404,"message":
  - "Can't find artifacts containing file conclusion.txt"}:
  - Task: https://cirrus-ci.com/task/5387833288949760
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5387833288949760/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/887f8cf2a1b5


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
Re: selftests/net: add MPTCP coverage for IP_LOCAL_PORT_RANGE: Tests Results
Posted by MPTCP CI 2 years, 2 months ago 
Hi Maxim,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- {"code":404,"message":
  - "Can't find artifacts containing file conclusion.txt"}:
  - Task: https://cirrus-ci.com/task/4513395882328064
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/4513395882328064/summary/summary.txt

- {"code":404,"message":
  - "Can't find artifacts containing file conclusion.txt"}:
  - Task: https://cirrus-ci.com/task/5076345835749376
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5076345835749376/summary/summary.txt

- {"code":404,"message":
  - "Can't find artifacts containing file conclusion.txt"}:
  - Task: https://cirrus-ci.com/task/5639295789170688
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5639295789170688/summary/summary.txt

- {"code":404,"message":
  - "Can't find artifacts containing file conclusion.txt"}:
  - Task: https://cirrus-ci.com/task/6202245742592000
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/6202245742592000/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/f1ef5a357e82


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.