mptcp: fill in missing MODULE_DESCRIPTION()

[PATCH mptcp-net] mptcp: fill in missing MODULE_DESCRIPTION()

Posted by Matthieu Baerts 2 years, 2 months ago

W=1 builds warn on missing MODULE_DESCRIPTION, add them here in MPTCP.

Only two were missing: two modules with different KUint tests for MPTCP.

Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
---
 net/mptcp/crypto_test.c | 1 +
 net/mptcp/token_test.c  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/net/mptcp/crypto_test.c b/net/mptcp/crypto_test.c
index 017248dea038..220414e5c850 100644
--- a/net/mptcp/crypto_test.c
+++ b/net/mptcp/crypto_test.c
@@ -70,3 +70,4 @@ static struct kunit_suite mptcp_crypto_suite = {
 kunit_test_suite(mptcp_crypto_suite);
 
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("KUnit tests for MPTCP Crypto");
diff --git a/net/mptcp/token_test.c b/net/mptcp/token_test.c
index 0758865ab658..bfff53e668da 100644
--- a/net/mptcp/token_test.c
+++ b/net/mptcp/token_test.c
@@ -143,3 +143,4 @@ static struct kunit_suite mptcp_token_suite = {
 kunit_test_suite(mptcp_token_suite);
 
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("KUnit tests for MPTCP Token");

---
base-commit: e7a5909d8593c93796bd85913fda617a08dfce7b
change-id: 20231127-mptcp-module-desc-f74500c2fd86

Best regards,
-- 
Matthieu Baerts <matttbe@kernel.org>

Re: mptcp: fill in missing MODULE_DESCRIPTION(): Tests Results

Posted by MPTCP CI 2 years, 2 months ago

Hi Matthieu,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- {"code":404,"message":
  - "Can't find artifacts containing file conclusion.txt"}:
  - Task: https://cirrus-ci.com/task/5892409620430848
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5892409620430848/summary/summary.txt

- {"code":404,"message":
  - "Can't find artifacts containing file conclusion.txt"}:
  - Task: https://cirrus-ci.com/task/5047984690298880
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5047984690298880/summary/summary.txt

- {"code":404,"message":
  - "Can't find artifacts containing file conclusion.txt"}:
  - Task: https://cirrus-ci.com/task/6455359573852160
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/6455359573852160/summary/summary.txt

- {"code":404,"message":
  - "Can't find artifacts containing file conclusion.txt"}:
  - Task: https://cirrus-ci.com/task/5329459667009536
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5329459667009536/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/139e66bd2b74


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)

Re: [PATCH mptcp-net] mptcp: fill in missing MODULE_DESCRIPTION()

Posted by Mat Martineau 2 years, 2 months ago

On Mon, 27 Nov 2023, Matthieu Baerts wrote:

> W=1 builds warn on missing MODULE_DESCRIPTION, add them here in MPTCP.
>
> Only two were missing: two modules with different KUint tests for MPTCP.
>
> Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
> ---
> net/mptcp/crypto_test.c | 1 +
> net/mptcp/token_test.c  | 1 +
> 2 files changed, 2 insertions(+)

Looks good:

Reviewed-by: Mat Martineau <martineau@kernel.org>

>
> diff --git a/net/mptcp/crypto_test.c b/net/mptcp/crypto_test.c
> index 017248dea038..220414e5c850 100644
> --- a/net/mptcp/crypto_test.c
> +++ b/net/mptcp/crypto_test.c
> @@ -70,3 +70,4 @@ static struct kunit_suite mptcp_crypto_suite = {
> kunit_test_suite(mptcp_crypto_suite);
>
> MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("KUnit tests for MPTCP Crypto");
> diff --git a/net/mptcp/token_test.c b/net/mptcp/token_test.c
> index 0758865ab658..bfff53e668da 100644
> --- a/net/mptcp/token_test.c
> +++ b/net/mptcp/token_test.c
> @@ -143,3 +143,4 @@ static struct kunit_suite mptcp_token_suite = {
> kunit_test_suite(mptcp_token_suite);
>
> MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("KUnit tests for MPTCP Token");
>
> ---
> base-commit: e7a5909d8593c93796bd85913fda617a08dfce7b
> change-id: 20231127-mptcp-module-desc-f74500c2fd86
>
> Best regards,
> -- 
> Matthieu Baerts <matttbe@kernel.org>
>
>
>

Re: [PATCH mptcp-net] mptcp: fill in missing MODULE_DESCRIPTION()

Posted by Matthieu Baerts 2 years, 2 months ago

Hi Mat,

On 27/11/2023 19:16, Mat Martineau wrote:
> On Mon, 27 Nov 2023, Matthieu Baerts wrote:
> 
>> W=1 builds warn on missing MODULE_DESCRIPTION, add them here in MPTCP.
>>
>> Only two were missing: two modules with different KUint tests for MPTCP.
>>
>> Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
>> ---
>> net/mptcp/crypto_test.c | 1 +
>> net/mptcp/token_test.c  | 1 +
>> 2 files changed, 2 insertions(+)
> 
> Looks good:
> 
> Reviewed-by: Mat Martineau <martineau@kernel.org>
Thank you for the review!

Now in our tree (fixes for -net -- like similar changes that have been
done recently in the -net tree):

New patches for t/upstream-net and t/upstream:
- b19e20f82601: mptcp: fill in missing MODULE_DESCRIPTION()
- Results: cea6555e919d..3b4aab119303 (export-net)
- Results: 90689d8a1056..b1ca2c54c539 (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export-net/20231204T171711
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20231204T171711

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Re: mptcp: fill in missing MODULE_DESCRIPTION(): Tests Results

Posted by MPTCP CI 2 years, 2 months ago

Hi Matthieu,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join):
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/6256691835043840
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/6256691835043840/summary/summary.txt

- KVM Validation: debug (only selftest_mptcp_join):
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/5412266904911872
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5412266904911872/summary/summary.txt

- KVM Validation: debug (except selftest_mptcp_join):
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/5975216858333184
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5975216858333184/summary/summary.txt

- KVM Validation: normal (only selftest_mptcp_join):
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/4849316951490560
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/4849316951490560/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/c7a02c02a522


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)