[v1] ss: mptcp: print new info counters

[PATCH mptcp-iproute 0/3] ss: mptcp: print new info counters

Posted by Matthieu Baerts 8 months, 2 weeks ago

Some MPTCP counters from mptcp_info structure have been added in the
kernel but not in ss.

Before adding the new counters in patch 3/3, patch 1/3 makes sure all
unsigned counters are displayed as unsigned. Patch 2/3 displays all seq
related counters as decimal instead of hexadecimal.

Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
---
Matthieu Baerts (3):
      ss: mptcp: display info counters as unsigned
      ss: mptcp: display seq related counters as decimal
      ss: mptcp: print missing info counters

 misc/ss.c | 34 +++++++++++++++++++++++++---------
 1 file changed, 25 insertions(+), 9 deletions(-)
---
base-commit: 872148f54e35cb13aa6c9e48e52306cd469aaa53
change-id: 20230817-mptcp-issue-415-ss-mptcp-info-6-5-9d6fa5121fb0

Best regards,
-- 
Matthieu Baerts <matthieu.baerts@tessares.net>

Re: [PATCH mptcp-iproute 0/3] ss: mptcp: print new info counters

Posted by Andrea Claudi 8 months, 1 week ago

On Mon, Aug 21, 2023 at 05:27:25PM +0200, Matthieu Baerts wrote:
> Some MPTCP counters from mptcp_info structure have been added in the
> kernel but not in ss.
> 
> Before adding the new counters in patch 3/3, patch 1/3 makes sure all
> unsigned counters are displayed as unsigned. Patch 2/3 displays all seq
> related counters as decimal instead of hexadecimal.
> 
> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> ---
> Matthieu Baerts (3):
>       ss: mptcp: display info counters as unsigned
>       ss: mptcp: display seq related counters as decimal
>       ss: mptcp: print missing info counters
> 
>  misc/ss.c | 34 +++++++++++++++++++++++++---------
>  1 file changed, 25 insertions(+), 9 deletions(-)
> ---

For the series:
Acked-by: Andrea Claudi <aclaudi@redhat.com>

Re: [PATCH mptcp-iproute 0/3] ss: mptcp: print new info counters

Posted by Paolo Abeni 8 months, 1 week ago

On Mon, 2023-08-21 at 17:27 +0200, Matthieu Baerts wrote:
> Some MPTCP counters from mptcp_info structure have been added in the
> kernel but not in ss.
> 
> Before adding the new counters in patch 3/3, patch 1/3 makes sure all
> unsigned counters are displayed as unsigned. Patch 2/3 displays all seq
> related counters as decimal instead of hexadecimal.
> 
> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> ---
> Matthieu Baerts (3):
>       ss: mptcp: display info counters as unsigned
>       ss: mptcp: display seq related counters as decimal
>       ss: mptcp: print missing info counters
> 
>  misc/ss.c | 34 +++++++++++++++++++++++++---------
>  1 file changed, 25 insertions(+), 9 deletions(-)
> ---
> base-commit: 872148f54e35cb13aa6c9e48e52306cd469aaa53
> change-id: 20230817-mptcp-issue-415-ss-mptcp-info-6-5-9d6fa5121fb0
> 
> Best regards,

FWIS, LGTM, thanks!

Acked-by: Paolo Abeni <pabeni@redhat.com>

p.s. I actually have a local version of patch 3/3 that I forgot to
upstream... ;)