[v2] selftests: mptcp: format subtests results in TAP (part 2)

[PATCH mptcp-next v2 0/3] selftests: mptcp: format subtests results in TAP (part 2)

Posted by Matthieu Baerts 9 months, 3 weeks ago

As discussed at a previous meeting, it might be good to print the test
name earlier to avoid confusions when there is an issue: sometimes the
error is printed at the end of the previous test and then the test name
is printed.

While at it, the code has been uniformed and it allows new features,
e.g. colour support, see patch 2.

Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
---
Changes in v2:
- Address Paolo's comment in patch 1/2 to print info only if there is any.
- Add patch 3/3, a fix for -net, a bit unrelated but discussed when
  working on part 1
- Link to v1: https://lore.kernel.org/r/20230628144927.828117-1-matthieu.baerts@tessares.net/

---
Matthieu Baerts (3):
      selftests: mptcp: join: rework detailed report
      selftests: mptcp: join: colored results
      selftests: mptcp: join: only check for ip6tables if needed

 tools/testing/selftests/net/mptcp/mptcp_join.sh | 454 +++++++++++-------------
 tools/testing/selftests/net/mptcp/mptcp_lib.sh  |  38 ++
 2 files changed, 253 insertions(+), 239 deletions(-)
---
base-commit: 5fca7ce8c3c8d7badac7a9dd8b552bb221d91ee4
change-id: 20230621-mptcp-issue-368-selftests-subtests-3c29a649dcdd

Best regards,
-- 
Matthieu Baerts <matthieu.baerts@tessares.net>

Re: [PATCH mptcp-next v2 0/3] selftests: mptcp: format subtests results in TAP (part 2)

Posted by Paolo Abeni 9 months, 3 weeks ago

On Wed, 2023-07-12 at 13:33 +0200, Matthieu Baerts wrote:
> As discussed at a previous meeting, it might be good to print the test
> name earlier to avoid confusions when there is an issue: sometimes the
> error is printed at the end of the previous test and then the test name
> is printed.
> 
> While at it, the code has been uniformed and it allows new features,
> e.g. colour support, see patch 2.
> 
> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> ---
> Changes in v2:
> - Address Paolo's comment in patch 1/2 to print info only if there is any.
> - Add patch 3/3, a fix for -net, a bit unrelated but discussed when
>   working on part 1
> - Link to v1: https://lore.kernel.org/r/20230628144927.828117-1-matthieu.baerts@tessares.net/
> 
> ---
> Matthieu Baerts (3):
>       selftests: mptcp: join: rework detailed report
>       selftests: mptcp: join: colored results
>       selftests: mptcp: join: only check for ip6tables if needed
> 
>  tools/testing/selftests/net/mptcp/mptcp_join.sh | 454 +++++++++++-------------
>  tools/testing/selftests/net/mptcp/mptcp_lib.sh  |  38 ++
>  2 files changed, 253 insertions(+), 239 deletions(-)
> ---
> base-commit: 5fca7ce8c3c8d7badac7a9dd8b552bb221d91ee4
> change-id: 20230621-mptcp-issue-368-selftests-subtests-3c29a649dcdd
> 
> Best regards,

Series LGTM, thanks Matttbe !

Acked-by: Paolo Abeni <pabeni@redhat.com>

Re: [PATCH mptcp-next v2 0/3] selftests: mptcp: format subtests results in TAP (part 2)

Posted by Matthieu Baerts 9 months, 3 weeks ago

Hi Paolo,

On 12/07/2023 15:46, Paolo Abeni wrote:
> On Wed, 2023-07-12 at 13:33 +0200, Matthieu Baerts wrote:
>> As discussed at a previous meeting, it might be good to print the test
>> name earlier to avoid confusions when there is an issue: sometimes the
>> error is printed at the end of the previous test and then the test name
>> is printed.
>>
>> While at it, the code has been uniformed and it allows new features,
>> e.g. colour support, see patch 2.
>>
>> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
>> ---
>> Changes in v2:
>> - Address Paolo's comment in patch 1/2 to print info only if there is any.
>> - Add patch 3/3, a fix for -net, a bit unrelated but discussed when
>>   working on part 1
>> - Link to v1: https://lore.kernel.org/r/20230628144927.828117-1-matthieu.baerts@tessares.net/
>>
>> ---
>> Matthieu Baerts (3):
>>       selftests: mptcp: join: rework detailed report
>>       selftests: mptcp: join: colored results
>>       selftests: mptcp: join: only check for ip6tables if needed
>>
>>  tools/testing/selftests/net/mptcp/mptcp_join.sh | 454 +++++++++++-------------
>>  tools/testing/selftests/net/mptcp/mptcp_lib.sh  |  38 ++
>>  2 files changed, 253 insertions(+), 239 deletions(-)
>> ---
>> base-commit: 5fca7ce8c3c8d7badac7a9dd8b552bb221d91ee4
>> change-id: 20230621-mptcp-issue-368-selftests-subtests-3c29a649dcdd
>>
>> Best regards,
> 
> Series LGTM, thanks Matttbe !
> 
> Acked-by: Paolo Abeni <pabeni@redhat.com>

Thank you for the review!

Now in our tree (feat. for net-next):

New patches for t/upstream:
- b0d400ffb30a: selftests: mptcp: join: rework detailed report
- 8973057b67fb: selftests: mptcp: join: colored results
- 196ffdd8bf70: selftests: mptcp: join: only check for ip6tables if needed
- Results: 5fca7ce8c3c8..611b54c853d3 (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20230712T150953

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net