[v2] mptcp: selftests: join: support BusyBox and ShellCheck

[PATCH mptcp-next v2 0/2] mptcp: selftests: join: support BusyBox and ShellCheck

Matthieu Baerts posted 2 patches 1 year, 1 month ago

Diff against v1 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20230404-mptcp-selftests-join-busybox-shellcheck-v2-0-9113fa4d2ce2@tessares.net

Maintainers: Matthieu Baerts <matthieu.baerts@tessares.net>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>, Mat Martineau <mathew.j.martineau@linux.intel.com>

There is a newer version of this series

tools/testing/selftests/net/mptcp/mptcp_join.sh | 23 +++++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)

Expand all Fold all

[PATCH mptcp-next v2 0/2] mptcp: selftests: join: support BusyBox and ShellCheck

Posted by Matthieu Baerts 1 year, 1 month ago

Here are two simple modifications, not really fixing anything for us but
fixing issues for those using BusyBox like LKFT.

At least the first patch fixes a bug they have. They might switch to a
different version of cmp at some points but it doesn't seem easy. So
probably best to have this patch flagged as a fix to have it backported
in order to detect when other mptcp_join.sh subtests are failing.

The second patch fixes ShellCheck warnings: it was reporting issues for
most lines of the script. Best to fix these warnings to easily spot new
warnings that could be linked to real issues. But no need to backport
this one I suppose.

Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
---
Changes in v2:
- Patch 1/2 now shrink files instead of doing something useless
- Link to v1: https://lore.kernel.org/r/20230404-mptcp-selftests-join-busybox-shellcheck-v1-0-65892428a951@tessares.net

---
Matthieu Baerts (2):
      selftests: mptcp: join: avoid using 'cmp --bytes'
      selftests: mptcp: join: fix ShellCheck warnings

 tools/testing/selftests/net/mptcp/mptcp_join.sh | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)
---
base-commit: 73fd52db48d9eff550fef735066f742acc2bf0e6
change-id: 20230404-mptcp-selftests-join-busybox-shellcheck-ec239f8d4e8f

Best regards,
-- 
Matthieu Baerts <matthieu.baerts@tessares.net>