selftests: mptcp: userspace pm: fix printed values

[PATCH mptcp-next] selftests: mptcp: userspace pm: fix printed values

Posted by Matthieu Baerts 1 year, 2 months ago

In case of errors, the printed message had the expected and the seen
value inverted.

This patch simply correct the order: first the expected value, then the
one that has been seen.

Fixes: 10d4273411be ("selftests: mptcp: userspace: print error details if any")
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
---
 tools/testing/selftests/net/mptcp/userspace_pm.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/mptcp/userspace_pm.sh b/tools/testing/selftests/net/mptcp/userspace_pm.sh
index 66c5be25c13d..48e52f995a98 100755
--- a/tools/testing/selftests/net/mptcp/userspace_pm.sh
+++ b/tools/testing/selftests/net/mptcp/userspace_pm.sh
@@ -240,7 +240,7 @@ check_expected_one()
 	fi
 
 	stdbuf -o0 -e0 printf "\tExpected value for '%s': '%s', got '%s'.\n" \
-		"${var}" "${!var}" "${!exp}"
+		"${var}" "${!exp}" "${!var}"
 	return 1
 }
 

---
base-commit: 744bdaf391bf58029612bec80f292805e349ae27
change-id: 20230216-mptcp-selftests-userspace-pm-typo-expected-e8774a556372

Best regards,
-- 
Matthieu Baerts <matthieu.baerts@tessares.net>

Re: [PATCH mptcp-next] selftests: mptcp: userspace pm: fix printed values

Posted by Geliang Tang 1 year, 2 months ago

Matthieu Baerts <matthieu.baerts@tessares.net> 于2023年2月16日周四 18:23写道：
>
> In case of errors, the printed message had the expected and the seen
> value inverted.
>
> This patch simply correct the order: first the expected value, then the
> one that has been seen.
>

Matt, this patch looks good, please add my acked-by tag:

Acked-by: Geliang Tang <geliang.tang@suse.com>

Thanks,
-Geliang

> Fixes: 10d4273411be ("selftests: mptcp: userspace: print error details if any")
> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> ---
>  tools/testing/selftests/net/mptcp/userspace_pm.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/mptcp/userspace_pm.sh b/tools/testing/selftests/net/mptcp/userspace_pm.sh
> index 66c5be25c13d..48e52f995a98 100755
> --- a/tools/testing/selftests/net/mptcp/userspace_pm.sh
> +++ b/tools/testing/selftests/net/mptcp/userspace_pm.sh
> @@ -240,7 +240,7 @@ check_expected_one()
>         fi
>
>         stdbuf -o0 -e0 printf "\tExpected value for '%s': '%s', got '%s'.\n" \
> -               "${var}" "${!var}" "${!exp}"
> +               "${var}" "${!exp}" "${!var}"
>         return 1
>  }
>
>
> ---
> base-commit: 744bdaf391bf58029612bec80f292805e349ae27
> change-id: 20230216-mptcp-selftests-userspace-pm-typo-expected-e8774a556372
>
> Best regards,
> --
> Matthieu Baerts <matthieu.baerts@tessares.net>
>
>

Re: [PATCH mptcp-next] selftests: mptcp: userspace pm: fix printed values

Posted by Matthieu Baerts 1 year, 2 months ago

Hi Geliang,

On 23/02/2023 06:55, Geliang Tang wrote:
> Matthieu Baerts <matthieu.baerts@tessares.net> 于2023年2月16日周四 18:23写道：
>>
>> In case of errors, the printed message had the expected and the seen
>> value inverted.
>>
>> This patch simply correct the order: first the expected value, then the
>> one that has been seen.
>>
> 
> Matt, this patch looks good, please add my acked-by tag:
> 
> Acked-by: Geliang Tang <geliang.tang@suse.com>

Thank you for your review!

Now in our tree (fix for -net):

New patches for t/upstream-net and t/upstream:
- ca6c4a980444: selftests: mptcp: userspace pm: fix printed values
- Results: 0b504c8bc901..32f1046d667c (export-net)
- Results: 6bb4cfee7e04..7264bacd3544 (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export-net/20230223T091254
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20230223T091254

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net