selftests: mptcp: stabilise 'endpoint' Join tests

[PATCH mptcp-net v2 0/2] selftests: mptcp: stabilise 'endpoint' Join tests

Matthieu Baerts posted 2 patches 1 year, 2 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20230131-mptcp-issue-323-join-delete-re-add-v2-0-8de2421163c9@tessares.net

Maintainers: Matthieu Baerts <matthieu.baerts@tessares.net>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>, Mat Martineau <mathew.j.martineau@linux.intel.com>

tools/testing/selftests/net/mptcp/mptcp_join.sh | 22 +++++++++++++++++-----
1 file changed, 17 insertions(+), 5 deletions(-)

Expand all Fold all

[PATCH mptcp-net v2 0/2] selftests: mptcp: stabilise 'endpoint' Join tests

Posted by Matthieu Baerts 1 year, 2 months ago

The first patch is the one of Paolo where I only added the
initialisation of "dump_stats" var as discussed on the mailing list.

The second patch is also somehow a fix as it stops the test earlier not
to wait quite a bit of time for nothing. It is good to have it now as
after the modification of patch 1/2, the waiting time is longer.

To: mptcp@lists.linux.dev

Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
---
Matthieu Baerts (1):
      selftests: mptcp: stop tests earlier

Paolo Abeni (1):
      selftests: mptcp: allow more slack for slow test-case

 tools/testing/selftests/net/mptcp/mptcp_join.sh | 22 +++++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)
---
base-commit: 0825e0ffa15862dc5c95b2195656f250a47be8ae
change-id: 20230131-mptcp-issue-323-join-delete-re-add-48a8d8d06120

Best regards,
-- 
Matthieu Baerts <matthieu.baerts@tessares.net>

Re: [PATCH mptcp-net v2 0/2] selftests: mptcp: stabilise 'endpoint' Join tests

Posted by Matthieu Baerts 1 year, 2 months ago

Hello,

On 31/01/2023 12:23, Matthieu Baerts wrote:
> The first patch is the one of Paolo where I only added the
> initialisation of "dump_stats" var as discussed on the mailing list.
> 
> The second patch is also somehow a fix as it stops the test earlier not
> to wait quite a bit of time for nothing. It is good to have it now as
> after the modification of patch 1/2, the waiting time is longer.

I just applied these two patches after having replied to Geliang's
questions. I hope that's OK

@Geliang: can I add your Acked-by? (I didn't added yet as they were not
explicitly there, thus my script didn't add them automatically :) )

New patches for t/upstream-net:
- 23bbeff9e3c6: selftests: mptcp: allow more slack for slow test-case
- 98d24d468734: selftests: mptcp: stop tests earlier
- Results: b5041e5446ed..d1ac838733b6 (export-net)
- Results: c22959a266e5..8b2ca48295cf (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export-net/20230202T133022
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20230202T133022

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net