[v1] mptcp: fix request sock for subflow in v6

[PATCH mptcp-net 0/3] mptcp: fix request sock for subflow in v6

Matthieu Baerts posted 3 patches 1 year, 4 months ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20221129210804.3769157-1-matthieu.baerts@tessares.net

Maintainers: Mat Martineau <mathew.j.martineau@linux.intel.com>, Matthieu Baerts <matthieu.baerts@tessares.net>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>, David Ahern <dsahern@kernel.org>, Florian Westphal <fw@strlen.de>, Christoph Paasch <cpaasch@apple.com>, Peter Krystad <peter.krystad@linux.intel.com>, Davide Caratti <dcaratti@redhat.com>

There is a newer version of this series

include/net/mptcp.h   | 12 +++++++--
net/ipv4/syncookies.c |  7 +++--
net/mptcp/subflow.c   | 61 ++++++++++++++++++++++++++++++++++++-------
3 files changed, 64 insertions(+), 16 deletions(-)

Expand all Fold all

[PATCH mptcp-net 0/3] mptcp: fix request sock for subflow in v6

Posted by Matthieu Baerts 1 year, 4 months ago

When working on validating the listener part of TCP FastOpen with Packetdrill, I
noticed the cookie in IPv6 was not the expected one.

The root cause was that req->rsk_ops->family was set to AF_INET while the
subflow was in v6. Patch 2/3 solves that.

While looking around, I noticed we were always calling the destructor from TCP
in v4 and I changed that in patch 3/3. I don't think there is a memory leaks in
usual cases.

Paolo did a pre-review (thanks again for that!) and suggested the patch 1/3.

Matthieu Baerts (3):
  mptcp: remove MPTCP 'ifdef' in TCP SYN cookies
  mptcp: dedicated request sock for subflow in v6
  mptcp: use proper req destructor for IPv6

 include/net/mptcp.h   | 12 +++++++--
 net/ipv4/syncookies.c |  7 +++--
 net/mptcp/subflow.c   | 61 ++++++++++++++++++++++++++++++++++++-------
 3 files changed, 64 insertions(+), 16 deletions(-)


base-commit: 8b052cb09c12ccbcf7086bd7f35146941dd337a3
-- 
2.37.2