net/mptcp/fastopen.c | 8 ++++---- net/mptcp/protocol.h | 8 ++++---- net/mptcp/subflow.c | 6 +++--- tools/testing/selftests/net/mptcp/mptcp_connect.c | 1 - 4 files changed, 11 insertions(+), 12 deletions(-)
Just some small quick fixes about "issues" I saw when I applied the patches last
week. Nothing important: function names, place in the .h and small checkpatch
splats.
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Dmytro Shytyi <dmytro@shytyi.net>
Matthieu Baerts (5):
Squash-to: "mptcp: implement delayed seq generation for passive
fastopen"
Squash-to (part 1): "mptcp: add subflow_v(4,6)_send_synack()"
Squash-to (part 2): "mptcp: add subflow_v(4,6)_send_synack()"
Squash-to (part 3): "mptcp: add subflow_v(4,6)_send_synack()"
Squash-to: "selftests: mptcp: mptfo Initiator/Listener"
net/mptcp/fastopen.c | 8 ++++----
net/mptcp/protocol.h | 8 ++++----
net/mptcp/subflow.c | 6 +++---
tools/testing/selftests/net/mptcp/mptcp_connect.c | 1 -
4 files changed, 11 insertions(+), 12 deletions(-)
base-commit: ff1606d98e1c56fd9f181210e5463528173e99c5
--
2.37.2
Hello,
On 14/11/2022 17:45, Matthieu Baerts wrote:
> Just some small quick fixes about "issues" I saw when I applied the patches last
> week. Nothing important: function names, place in the .h and small checkpatch
> splats.
An additional thing to do is to update the commit message of the first
patch of the "TFO listener" series which is currently:
mptcp: introduce MSG_FASTOPEN flag
In the following patches we will analyse the MSG_FASTOPEN flag
in the mptcp_sendmsg() and invoke the MPTFO.
Maybe by:
mptcp: add MSG_FASTOPEN sendmsg flag support
Since commit 54f1944ed6d2 ("mptcp: factor out mptcp_connect()") from
Paolo Abeni, all the infrastructure is now in place to support this
flag.
The remaining action to do is to allow it and treat it as a fastopen
message to be able to access this:
sendto(sockfd, ..., ..., MSG_FASTOPEN, ..., ...);
What do you think?
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
On Mon, 2022-11-14 at 17:58 +0100, Matthieu Baerts wrote:
> Hello,
>
> On 14/11/2022 17:45, Matthieu Baerts wrote:
> > Just some small quick fixes about "issues" I saw when I applied the patches last
> > week. Nothing important: function names, place in the .h and small checkpatch
> > splats.
>
> An additional thing to do is to update the commit message of the first
> patch of the "TFO listener" series which is currently:
>
> mptcp: introduce MSG_FASTOPEN flag
>
> In the following patches we will analyse the MSG_FASTOPEN flag
> in the mptcp_sendmsg() and invoke the MPTFO.
>
> Maybe by:
>
> mptcp: add MSG_FASTOPEN sendmsg flag support
>
> Since commit 54f1944ed6d2 ("mptcp: factor out mptcp_connect()") from
> Paolo Abeni, all the infrastructure is now in place to support this
> flag.
>
> The remaining action to do is to allow it and treat it as a fastopen
> message to be able to access this:
>
> sendto(sockfd, ..., ..., MSG_FASTOPEN, ..., ...);
>
> What do you think?
Possibly something a little less verbose? Alike:
"""
mptcp: add MSG_FASTOPEN sendmsg flag support
Since commit 54f1944ed6d2 ("mptcp: factor out mptcp_connect()") all the
infrastructure is now in place to support the MSG_FASTOPEN flag, we
just need to call into the fastopen path in mptcp_sendmsg()
"""
?
Hi Paolo,
On 14/11/2022 18:08, Paolo Abeni wrote:
> On Mon, 2022-11-14 at 17:58 +0100, Matthieu Baerts wrote:
>> Hello,
>>
>> On 14/11/2022 17:45, Matthieu Baerts wrote:
>>> Just some small quick fixes about "issues" I saw when I applied the patches last
>>> week. Nothing important: function names, place in the .h and small checkpatch
>>> splats.
>>
>> An additional thing to do is to update the commit message of the first
>> patch of the "TFO listener" series which is currently:
>>
>> mptcp: introduce MSG_FASTOPEN flag
>>
>> In the following patches we will analyse the MSG_FASTOPEN flag
>> in the mptcp_sendmsg() and invoke the MPTFO.
>>
>> Maybe by:
>>
>> mptcp: add MSG_FASTOPEN sendmsg flag support
>>
>> Since commit 54f1944ed6d2 ("mptcp: factor out mptcp_connect()") from
>> Paolo Abeni, all the infrastructure is now in place to support this
>> flag.
>>
>> The remaining action to do is to allow it and treat it as a fastopen
>> message to be able to access this:
>>
>> sendto(sockfd, ..., ..., MSG_FASTOPEN, ..., ...);
>>
>> What do you think?
>
> Possibly something a little less verbose? Alike:
>
> """
> mptcp: add MSG_FASTOPEN sendmsg flag support
>
> Since commit 54f1944ed6d2 ("mptcp: factor out mptcp_connect()") all the
> infrastructure is now in place to support the MSG_FASTOPEN flag, we
> just need to call into the fastopen path in mptcp_sendmsg()
> """
I know you would prefer a version without your name :-)
Sure, it is good to me!
Is it OK for you if I do the modifications and apply the 5 other small
patches? (no hurry :) )
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
On Mon, 2022-11-14 at 18:11 +0100, Matthieu Baerts wrote:
> Hi Paolo,
>
> On 14/11/2022 18:08, Paolo Abeni wrote:
> > On Mon, 2022-11-14 at 17:58 +0100, Matthieu Baerts wrote:
> > > Hello,
> > >
> > > On 14/11/2022 17:45, Matthieu Baerts wrote:
> > > > Just some small quick fixes about "issues" I saw when I applied the patches last
> > > > week. Nothing important: function names, place in the .h and small checkpatch
> > > > splats.
> > >
> > > An additional thing to do is to update the commit message of the first
> > > patch of the "TFO listener" series which is currently:
> > >
> > > mptcp: introduce MSG_FASTOPEN flag
> > >
> > > In the following patches we will analyse the MSG_FASTOPEN flag
> > > in the mptcp_sendmsg() and invoke the MPTFO.
> > >
> > > Maybe by:
> > >
> > > mptcp: add MSG_FASTOPEN sendmsg flag support
> > >
> > > Since commit 54f1944ed6d2 ("mptcp: factor out mptcp_connect()") from
> > > Paolo Abeni, all the infrastructure is now in place to support this
> > > flag.
> > >
> > > The remaining action to do is to allow it and treat it as a fastopen
> > > message to be able to access this:
> > >
> > > sendto(sockfd, ..., ..., MSG_FASTOPEN, ..., ...);
> > >
> > > What do you think?
> >
> > Possibly something a little less verbose? Alike:
> >
> > """
> > mptcp: add MSG_FASTOPEN sendmsg flag support
> >
> > Since commit 54f1944ed6d2 ("mptcp: factor out mptcp_connect()") all the
> > infrastructure is now in place to support the MSG_FASTOPEN flag, we
> > just need to call into the fastopen path in mptcp_sendmsg()
> > """
>
> I know you would prefer a version without your name :-)
>
> Sure, it is good to me!
>
> Is it OK for you if I do the modifications and apply the 5 other small
> patches? (no hurry :) )
[browsers!] Sure, please go ahead. I have a couple of additional
fastopen follow-ups pending...
/P
Hi Paolo, On 15/11/2022 16:22, Paolo Abeni wrote: > [browsers!] Sure, please go ahead. I have a couple of additional > fastopen follow-ups pending... Thank you for the review! I just applied these patches in our tree: - 30d542994e3b: "squashed" (with conflicts) patch 1/5 in "mptcp: implement delayed seq generation for passive fastopen" - da41e5fb2e69: conflict in t/mptcp-add-subflow_v-4-6-_send_synack - 183032806905: "squashed" patch 2/5 in "mptcp: add subflow_v(4,6)_send_synack()" - 8e2de0e11c9c: "squashed" patch 3/5 in "mptcp: add subflow_v(4,6)_send_synack()" - 8e7208654410: "squashed" patch 4/5 in "mptcp: add subflow_v(4,6)_send_synack()" - a1456d147b4e: "squashed" patch 5/5 in "selftests: mptcp: mptfo Initiator/Listener" - Results: 90b37ad8479c..a3b1d1930a5c (export) Tests are now in progress: https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20221115T154226 Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net
Hi Paolo,
On 15/11/2022 16:22, Paolo Abeni wrote:
> On Mon, 2022-11-14 at 18:11 +0100, Matthieu Baerts wrote:
>> Hi Paolo,
>>
>> On 14/11/2022 18:08, Paolo Abeni wrote:
>>> On Mon, 2022-11-14 at 17:58 +0100, Matthieu Baerts wrote:
>>>> Hello,
>>>>
>>>> On 14/11/2022 17:45, Matthieu Baerts wrote:
>>>>> Just some small quick fixes about "issues" I saw when I applied the patches last
>>>>> week. Nothing important: function names, place in the .h and small checkpatch
>>>>> splats.
>>>>
>>>> An additional thing to do is to update the commit message of the first
>>>> patch of the "TFO listener" series which is currently:
>>>>
>>>> mptcp: introduce MSG_FASTOPEN flag
>>>>
>>>> In the following patches we will analyse the MSG_FASTOPEN flag
>>>> in the mptcp_sendmsg() and invoke the MPTFO.
>>>>
>>>> Maybe by:
>>>>
>>>> mptcp: add MSG_FASTOPEN sendmsg flag support
>>>>
>>>> Since commit 54f1944ed6d2 ("mptcp: factor out mptcp_connect()") from
>>>> Paolo Abeni, all the infrastructure is now in place to support this
>>>> flag.
>>>>
>>>> The remaining action to do is to allow it and treat it as a fastopen
>>>> message to be able to access this:
>>>>
>>>> sendto(sockfd, ..., ..., MSG_FASTOPEN, ..., ...);
>>>>
>>>> What do you think?
>>>
>>> Possibly something a little less verbose? Alike:
>>>
>>> """
>>> mptcp: add MSG_FASTOPEN sendmsg flag support
>>>
>>> Since commit 54f1944ed6d2 ("mptcp: factor out mptcp_connect()") all the
>>> infrastructure is now in place to support the MSG_FASTOPEN flag, we
>>> just need to call into the fastopen path in mptcp_sendmsg()
>>> """
>>
>> I know you would prefer a version without your name :-)
>>
>> Sure, it is good to me!
>>
>> Is it OK for you if I do the modifications and apply the 5 other small
>> patches? (no hurry :) )
>
> [browsers!]
We told you not to use IE6 anymore...
> Sure, please go ahead. I have a couple of additional
> fastopen follow-ups pending...
Thanks! I can apply now not to block you :)
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
© 2016 - 2024 Red Hat, Inc.