net/mptcp/token.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
We kept getting initial patches from new contributors to remove a
duplicate 'the' (since grammar checking scripts flag it), but submitters
never followed up after code review.
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
---
net/mptcp/token.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/mptcp/token.c b/net/mptcp/token.c
index f52ee7b26aed..65430f314a68 100644
--- a/net/mptcp/token.c
+++ b/net/mptcp/token.c
@@ -287,8 +287,8 @@ EXPORT_SYMBOL_GPL(mptcp_token_get_sock);
* This function returns the first mptcp connection structure found inside the
* token container starting from the specified position, or NULL.
*
- * On successful iteration, the iterator is move to the next position and the
- * the acquires a reference to the returned socket.
+ * On successful iteration, the iterator is moved to the next position and
+ * a reference to the returned socket is acquired.
*/
struct mptcp_sock *mptcp_token_iter_next(const struct net *net, long *s_slot,
long *s_num)
--
2.38.1
Hi Mat, On 01/11/2022 21:55, Mat Martineau wrote: > We kept getting initial patches from new contributors to remove a > duplicate 'the' (since grammar checking scripts flag it), but submitters > never followed up after code review. Thank you for the patch! As discussed at the last meeting, OK to apply as it is: Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net> Now in our tree (feat. for net-next): New patches for t/upstream: - c98a6a04fe47: mptcp: Fix grammar in a comment - Results: c40114c3c367..5b48361cc96d (export) Tests are now in progress: https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20221103T171741 Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net
Hi Mat, On 01/11/2022 21:55, Mat Martineau wrote: > We kept getting initial patches from new contributors to remove a > duplicate 'the' (since grammar checking scripts flag it), but submitters > never followed up after code review. Thank you for taking care of this! This looks good to me of course. Just a small question: do we need to mention anybody? Maybe not these new contributors as they seem to ignore the previous requests but maybe Bagas Sanjaya who commented on netdev? Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net
Hi Mat, Thank you for your modifications, that's great! Our CI did some validations and here is its report: - KVM Validation: normal: - Unstable: 1 failed test(s): selftest_simult_flows 🔴: - Task: https://cirrus-ci.com/task/6510945403928576 - Summary: https://api.cirrus-ci.com/v1/artifact/task/6510945403928576/summary/summary.txt - KVM Validation: debug: - Success! ✅: - Task: https://cirrus-ci.com/task/4681358055309312 - Summary: https://api.cirrus-ci.com/v1/artifact/task/4681358055309312/summary/summary.txt Initiator: Patchew Applier Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/5f6b7ec4cbf2 If there are some issues, you can reproduce them using the same environment as the one used by the CI thanks to a docker image, e.g.: $ cd [kernel source code] $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \ --pull always mptcp/mptcp-upstream-virtme-docker:latest \ auto-debug For more details: https://github.com/multipath-tcp/mptcp-upstream-virtme-docker Please note that despite all the efforts that have been already done to have a stable tests suite when executed on a public CI like here, it is possible some reported issues are not due to your modifications. Still, do not hesitate to help us improve that ;-) Cheers, MPTCP GH Action bot Bot operated by Matthieu Baerts (Tessares)
© 2016 - 2024 Red Hat, Inc.