[PATCH] net/mptcp: fix repeated words in comments

wangjianli posted 1 patch 1 month, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20221022070527.55960-1-wangjianli@cdjrlc.com
Maintainers: Mat Martineau <mathew.j.martineau@linux.intel.com>, Matthieu Baerts <matthieu.baerts@tessares.net>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
net/mptcp/token.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] net/mptcp: fix repeated words in comments
Posted by wangjianli 1 month, 2 weeks ago
Delete the redundant word 'the'.

Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
---
 net/mptcp/token.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mptcp/token.c b/net/mptcp/token.c
index f52ee7b26aed..b817c2564300 100644
--- a/net/mptcp/token.c
+++ b/net/mptcp/token.c
@@ -287,7 +287,7 @@ EXPORT_SYMBOL_GPL(mptcp_token_get_sock);
  * This function returns the first mptcp connection structure found inside the
  * token container starting from the specified position, or NULL.
  *
- * On successful iteration, the iterator is move to the next position and the
+ * On successful iteration, the iterator is move to the next position and
  * the acquires a reference to the returned socket.
  */
 struct mptcp_sock *mptcp_token_iter_next(const struct net *net, long *s_slot,
-- 
2.36.1
Re: [PATCH] net/mptcp: fix repeated words in comments
Posted by Bagas Sanjaya 1 month, 2 weeks ago
On Sat, Oct 22, 2022 at 03:05:27PM +0800, wangjianli wrote:
> Delete the redundant word 'the'.
> 
> Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
> ---
>  net/mptcp/token.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/mptcp/token.c b/net/mptcp/token.c
> index f52ee7b26aed..b817c2564300 100644
> --- a/net/mptcp/token.c
> +++ b/net/mptcp/token.c
> @@ -287,7 +287,7 @@ EXPORT_SYMBOL_GPL(mptcp_token_get_sock);
>   * This function returns the first mptcp connection structure found inside the
>   * token container starting from the specified position, or NULL.
>   *
> - * On successful iteration, the iterator is move to the next position and the
> + * On successful iteration, the iterator is move to the next position and
>   * the acquires a reference to the returned socket.
>   */
>  struct mptcp_sock *mptcp_token_iter_next(const struct net *net, long *s_slot,

NAK!

Instead, slightly reword the comment above as "On successful iteration,
the iterator moves to the next position and acquires a reference to the
returned socket.".

Also, you and other @cdjrlc.com developers ignore reviews that request
changes to your patches. If you want to participate in kernel
development community, please don't just sending random patches without
any sort of reply.

I have pointed out this behavior either as part of my review or as reply
to reviews from other developers. I may write this as final warning before
I just say NAK without further ado to your future patches.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara
Re: [PATCH] net/mptcp: fix repeated words in comments
Posted by Mat Martineau 1 month, 2 weeks ago
On Sun, 23 Oct 2022, Bagas Sanjaya wrote:

> On Sat, Oct 22, 2022 at 03:05:27PM +0800, wangjianli wrote:
>> Delete the redundant word 'the'.
>>
>> Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
>> ---
>>  net/mptcp/token.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/mptcp/token.c b/net/mptcp/token.c
>> index f52ee7b26aed..b817c2564300 100644
>> --- a/net/mptcp/token.c
>> +++ b/net/mptcp/token.c
>> @@ -287,7 +287,7 @@ EXPORT_SYMBOL_GPL(mptcp_token_get_sock);
>>   * This function returns the first mptcp connection structure found inside the
>>   * token container starting from the specified position, or NULL.
>>   *
>> - * On successful iteration, the iterator is move to the next position and the
>> + * On successful iteration, the iterator is move to the next position and
>>   * the acquires a reference to the returned socket.
>>   */
>>  struct mptcp_sock *mptcp_token_iter_next(const struct net *net, long *s_slot,
>
> NAK!
>
> Instead, slightly reword the comment above as "On successful iteration,
> the iterator moves to the next position and acquires a reference to the
> returned socket.".
>

Agree on this rewording.

This particular duplicated word came up before, and I thought it would be 
best if the author sent a v2 - but they never did. I will fix this in the 
MPTCP tree next week if there's no suitable v2 by then.

--
Mat Martineau
Intel
Re: net/mptcp: fix repeated words in comments: Tests Results
Posted by MPTCP CI 1 month, 2 weeks ago
Hi wangjianli,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal:
  - Unstable: 1 failed test(s): selftest_simult_flows 🔴:
  - Task: https://cirrus-ci.com/task/6615523631300608
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/6615523631300608/summary/summary.txt

- {"code":404,"message":
  - "Can't find artifacts containing file conclusion.txt"}:
  - Task: https://cirrus-ci.com/task/4574830050148352
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/4574830050148352/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/1240b7ce4b18


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)