On Tue, 18 Oct 2022, Geliang Tang wrote:
> v9:
> - move "register default scheduler" out of this series.
> - add missing "first = false" in patch 4
> - patch 2 could be merged before the commit "mptcp: add
> struct mptcp_sched_ops" as a non-bpf cleanup.
>
The first 3 patches look good to me:
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
I have some other comments for patch 4.
> v8:
> - merge "register default scheduler" into this series.
> - Move "multi-subflow scheduling" out of this series.
> - This series should be merged between the commit "mptcp: add get_subflow
> wrappers" and "bpf: Add bpf_mptcp_sched_ops", except the squash-to patches.
>
> v7:
> - update delegate sending in patch 10
> - rebase to export/20221011T063543.
>
> v6:
> - drop all msk->last_snd, add last_snd variable instead in patch 13
> - fix lock_sock issue in patch 3
> - merge squash-to patches
>
> v5:
> - address Mat's comments in v4.
>
> v4:
> - update __mptcp_subflow_push_pending as Mat suggested.
> - add more patches from "BPF redundant scheduler" series.
>
> v3:
> - add a cleanup patch.
> - remove msk->last_snd in mptcp_subflow_get_send().
> - add the loop that calls the scheduler again in __mptcp_push_pending().
>
> v2:
> - add snd_burst check in dfrags loop as Mat suggested.
>
> Refactor __mptcp_push_pending() and __mptcp_subflow_push_pending() to
> remove duplicate code and support redundant scheduler more easily in
> __mptcp_subflow_push_pending().
>
> Geliang Tang (4):
> Squash to "mptcp: add get_subflow wrappers"
> mptcp: use msk instead of mptcp_sk
> mptcp: change 'first' as a parameter
> mptcp: refactor push_pending logic
>
> net/mptcp/protocol.c | 183 +++++++++++++++++++------------------------
> net/mptcp/protocol.h | 4 +-
> net/mptcp/sched.c | 61 +++++++--------
> 3 files changed, 111 insertions(+), 137 deletions(-)
>
> --
> 2.35.3
>
>
>
--
Mat Martineau
Intel