[RFC PATCH mptcp-next v7 01/11] Add separate fastopen.c file.

Dmytro Shytyi posted 11 patches 3 years, 4 months ago
There is a newer version of this series
[RFC PATCH mptcp-next v7 01/11] Add separate fastopen.c file.
Posted by Dmytro Shytyi 3 years, 4 months ago
Add separate *.c file. Function prototypes are coming to protocol.h
(Suggestion of @palbeni (JUN 17))

Signed-off-by: Dmytro Shytyi <dmytro@shytyi.net>
---
 net/mptcp/Makefile   | 2 +-
 net/mptcp/fastopen.c | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)
 create mode 100644 net/mptcp/fastopen.c

diff --git a/net/mptcp/Makefile b/net/mptcp/Makefile
index 8a7f68efa35f..c42ad8609876 100644
--- a/net/mptcp/Makefile
+++ b/net/mptcp/Makefile
@@ -2,7 +2,7 @@
 obj-$(CONFIG_MPTCP) += mptcp.o
 
 mptcp-y := protocol.o subflow.o options.o token.o crypto.o ctrl.o pm.o diag.o \
-	   mib.o pm_netlink.o sockopt.o pm_userspace.o sched.o
+	   mib.o pm_netlink.o sockopt.o pm_userspace.o sched.o fastopen.o
 
 obj-$(CONFIG_SYN_COOKIES) += syncookies.o
 obj-$(CONFIG_INET_MPTCP_DIAG) += mptcp_diag.o
diff --git a/net/mptcp/fastopen.c b/net/mptcp/fastopen.c
new file mode 100644
index 000000000000..0c9ef6f5d528
--- /dev/null
+++ b/net/mptcp/fastopen.c
@@ -0,0 +1,5 @@
+/* SPDX-License-Identifier: GPL-2.0
+ * MPTCP Fast Open Mechanism. Copyright (c) 2021-2022, Dmytro SHYTYI
+ */
+
+#include "protocol.h"
-- 
2.25.1



Re: [RFC PATCH mptcp-next v7 01/11] Add separate fastopen.c file.
Posted by Paolo Abeni 3 years, 4 months ago
On Sun, 2022-09-18 at 00:28 +0200, Dmytro Shytyi wrote:
> Add separate *.c file. Function prototypes are coming to protocol.h
> (Suggestion of @palbeni (JUN 17))
> 
> Signed-off-by: Dmytro Shytyi <dmytro@shytyi.net>

It's probaly better to squash this patch in 3/11, so fastopen.c will
not be a completelly empty skelethon.

Thanks,

Paolo
Re: [RFC PATCH mptcp-next v7 01/11] Add separate fastopen.c file.
Posted by Dmytro Shytyi 3 years, 4 months ago
Hello,

It is done in v8.

Thanks,

Dmytro

On 9/19/2022 12:21 PM, Paolo Abeni wrote:
> On Sun, 2022-09-18 at 00:28 +0200, Dmytro Shytyi wrote:
>> Add separate *.c file. Function prototypes are coming to protocol.h
>> (Suggestion of @palbeni (JUN 17))
>>
>> Signed-off-by: Dmytro Shytyi <dmytro@shytyi.net>
> It's probaly better to squash this patch in 3/11, so fastopen.c will
> not be a completelly empty skelethon.
>
> Thanks,
>
> Paolo
>