[PATCH] mptcp: Fix comment typo

Jason Wang posted 1 patch 2 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20220716044226.43587-1-wangborong@cdjrlc.com
Maintainers: Mat Martineau <mathew.j.martineau@linux.intel.com>, Eric Dumazet <edumazet@google.com>, Matthieu Baerts <matthieu.baerts@tessares.net>, "David S. Miller" <davem@davemloft.net>, Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>
net/mptcp/token.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] mptcp: Fix comment typo
Posted by Jason Wang 2 months, 2 weeks ago
The double `the' is duplicated in the comment, remove one.

Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
 net/mptcp/token.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mptcp/token.c b/net/mptcp/token.c
index f52ee7b26aed..68b822691e36 100644
--- a/net/mptcp/token.c
+++ b/net/mptcp/token.c
@@ -288,7 +288,7 @@ EXPORT_SYMBOL_GPL(mptcp_token_get_sock);
  * token container starting from the specified position, or NULL.
  *
  * On successful iteration, the iterator is move to the next position and the
- * the acquires a reference to the returned socket.
+ * acquires a reference to the returned socket.
  */
 struct mptcp_sock *mptcp_token_iter_next(const struct net *net, long *s_slot,
 					 long *s_num)
-- 
2.35.1


Re: [PATCH] mptcp: Fix comment typo
Posted by Mat Martineau 2 months, 1 week ago
On Sat, 16 Jul 2022, Jason Wang wrote:

> The double `the' is duplicated in the comment, remove one.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> net/mptcp/token.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mptcp/token.c b/net/mptcp/token.c
> index f52ee7b26aed..68b822691e36 100644
> --- a/net/mptcp/token.c
> +++ b/net/mptcp/token.c
> @@ -288,7 +288,7 @@ EXPORT_SYMBOL_GPL(mptcp_token_get_sock);
>  * token container starting from the specified position, or NULL.
>  *
>  * On successful iteration, the iterator is move to the next position and the

Two more changes are needed in the line above:

move -> moved
the -> then

Thanks for the contribution.

> - * the acquires a reference to the returned socket.
> + * acquires a reference to the returned socket.
>  */
> struct mptcp_sock *mptcp_token_iter_next(const struct net *net, long *s_slot,
> 					 long *s_num)
> -- 
> 2.35.1
>
>

--
Mat Martineau
Intel

Re: mptcp: Fix comment typo: Tests Results
Posted by MPTCP CI 2 months, 1 week ago
Hi Jason,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal:
  - Unstable: 1 failed test(s): selftest_mptcp_join 🔴:
  - Task: https://cirrus-ci.com/task/5398489659080704
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5398489659080704/summary/summary.txt

- {"code":404,"message":
  - "Can't find artifacts containing file conclusion.txt"}:
  - Task: https://cirrus-ci.com/task/6524389565923328
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/6524389565923328/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/a3d94f3f9ae5


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)