[v2] mptcp: fix bug in userspace PM APIs

[PATCH mptcp-next v2 0/3] mptcp: fix bug in userspace PM APIs

Kishen Maloor posted 3 patches 2 years ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20220420042524.2268380-1-kishen.maloor@intel.com

Maintainers: Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Mat Martineau <mathew.j.martineau@linux.intel.com>, "David S. Miller" <davem@davemloft.net>, Matthieu Baerts <matthieu.baerts@tessares.net>

net/mptcp/pm_userspace.c | 93 +++++++++++++++++++++++-----------------
1 file changed, 53 insertions(+), 40 deletions(-)

Expand all Fold all

[PATCH mptcp-next v2 0/3] mptcp: fix bug in userspace PM APIs

Posted by Kishen Maloor 2 years ago

This series fixes issue #267:
https://github.com/multipath-tcp/mptcp_net-next/issues/267

Specifically, calls to mptcp_token_get_sock() from userspace PM APIs
hold a reference to the msk which needs to be freed before leaving those
functions. This was causing a memory leak which was caught in
the CI debug build.

v2:
-Fixed code style.

Kishen Maloor (3):
  Squash-to: mptcp: netlink: Add MPTCP_PM_CMD_ANNOUNCE
  Squash-to: mptcp: netlink: Add MPTCP_PM_CMD_REMOVE
  Squash-to: mptcp: netlink: allow userspace-driven subflow
    establishment

 net/mptcp/pm_userspace.c | 93 +++++++++++++++++++++++-----------------
 1 file changed, 53 insertions(+), 40 deletions(-)


base-commit: e561667a821b0ecccba582520829f38da50567a3
--
2.31.1

Re: [PATCH mptcp-next v2 0/3] mptcp: fix bug in userspace PM APIs

Posted by Matthieu Baerts 2 years ago

Hi Kishen, Geliang, Mat,

On 20/04/2022 06:25, Kishen Maloor wrote:
> This series fixes issue #267: 
> https://github.com/multipath-tcp/mptcp_net-next/issues/267
> 
> Specifically, calls to mptcp_token_get_sock() from userspace PM APIs 
> hold a reference to the msk which needs to be freed before leaving
> those functions. This was causing a memory leak which was caught in 
> the CI debug build.

Thank you for the patches and the reviews!

Please next time add more details in the different commit messages,
mainly the reason and ideally a "Closes:" tag.


Now in our tree:

New patches for t/upstream:
- b5427dca0016: "squashed" patch 1/3 in "mptcp: netlink: Add
MPTCP_PM_CMD_ANNOUNCE"
- 93a0837b24aa: "squashed" patch 2/3 in "mptcp: netlink: Add
MPTCP_PM_CMD_REMOVE"
- 1cfb03d21837: "squashed" patch 3/3 in "mptcp: netlink: allow
userspace-driven subflow establishment"
- Results: 8001d7b9c400..1e2cdcf7b0cc (export)


Builds and tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220420T152103

https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export


Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net