On Mon, 28 Mar 2022, Kishen Maloor wrote:
> This patch series incorporates fixes and enhancements related to
> path management over MPTCP connections, particularly in support of
> userspace PMs. The changes ensure that the required bits of
> information are conveyed through MPTCP netlink events which
> would be consumed by the path manager in making its decisions.
> Further it adds flexibility in establishing paths and from
> both ends of MPTCP connections.
>
> v6:
> -Dropped framework and functionality around the use of kernel
> listening sockets for receiving MPJs.
>
Thanks Kishen. This first series looks good to me, and Paolo acked too.
The second series needs a rebase and a few more tweaks.
For this series:
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Matthieu, I sent two additional selftest-only patches so that the behavior
implemented in this series (which is correct: don't send ADD_ADDR echoes
if there's no userspace daemon) is correctly tested. They're pretty short
and simple, hopefully you can review and apply with Kishen's series. As I
mentioned in
https://lore.kernel.org/mptcp/20220401193714.10268-1-mathew.j.martineau@linux.intel.com/
:
If you could add the squash-to patch at the beginning of [the] series to
revert the bad test, and add the new self test commit after "mptcp:
bypass in-kernel PM restrictions for non-kernel PMs" I think that
addresses the test problem.
Mat
> v7:
> -Fixed bug caught by the CI build.
>
> v8:
> -Fixed logic to achieve the desired outcome of not responding to
> address advertisements when a userspace PM is offline.
> -Factored out minor changes to mptcp_pm_is_userspace() to be
> squashed into an earlier commit.
>
> v9:
> -Removed an explicit 'struct inet_sock *' cast in a patch which was
> not necessary.
>
> Kishen Maloor (6):
> Squash-to: mptcp: Bypass kernel PM when userspace PM is enabled
> mptcp: bypass in-kernel PM restrictions for non-kernel PMs
> mptcp: store remote id from MP_JOIN SYN/ACK in local ctx
> mptcp: reflect remote port (not 0) in ANNOUNCED events
> mptcp: establish subflows from either end of connection
> mptcp: expose server_side attribute in MPTCP netlink events
>
> include/uapi/linux/mptcp.h | 1 +
> net/mptcp/options.c | 4 ++--
> net/mptcp/pm.c | 21 +++++++++++++++++----
> net/mptcp/pm_netlink.c | 24 +++++++++++++++++++++---
> net/mptcp/protocol.c | 5 +----
> net/mptcp/protocol.h | 22 ++++++++++++++++------
> net/mptcp/subflow.c | 5 ++++-
> 7 files changed, 62 insertions(+), 20 deletions(-)
>
>
> base-commit: 8e1fca01ac83e646133bd647abdae74d6d6449ba
> --
> 2.31.1
>
>
--
Mat Martineau
Intel