selftests: avoid confusions around 'signal invalid addresses'

[PATCH mptcp-net 0/2] selftests: avoid confusions around 'signal invalid addresses'

Matthieu Baerts posted 2 patches 2 years, 3 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20220122093135.4023846-1-matthieu.baerts@tessares.net

Maintainers: "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Matthieu Baerts <matthieu.baerts@tessares.net>, Yonglong Li <liyonglong@chinatelecom.cn>, Mat Martineau <mathew.j.martineau@linux.intel.com>, Geliang Tang <geliangtang@gmail.com>, Shuah Khan <shuah@kernel.org>, Paolo Abeni <pabeni@redhat.com>

include/net/mptcp.h                             | 6 ------
tools/testing/selftests/net/mptcp/mptcp_join.sh | 1 +
2 files changed, 1 insertion(+), 6 deletions(-)

Expand all Fold all

[PATCH mptcp-net 0/2] selftests: avoid confusions around 'signal invalid addresses'

Posted by Matthieu Baerts 2 years, 3 months ago

With Paolo, we were trying to understand why one test was failing, see:

https://github.com/multipath-tcp/mptcp_net-next/issues/254

Paolo noticed that even if the CI was reporting this:

  17 signal invalid addresses             syn[ ok ] - synack[ ok ] - ack[ ok ]
                                          add[ ok ] - echo  [ ok ]
                                          add[fail] got 2 ADD_ADDR[s] expected 3

The issue here was not with the 17th test but with the next one. This patch can
be sent to -net.

While at it, we can also fully remove mptcp_parse_option() from mptcp.h. Not
sure this patch needs to be sent to -net but it should not be rejected from
there :)

Matthieu Baerts (2):
  mptcp: mptcp_parse_option is no longer exported
  selftests: mptcp: add missing join check

 include/net/mptcp.h                             | 6 ------
 tools/testing/selftests/net/mptcp/mptcp_join.sh | 1 +
 2 files changed, 1 insertion(+), 6 deletions(-)

-- 
2.33.1