mptcp: fix crash with mptcp-ulp on tcp sockets

[PATCH mptcp 0/2] mptcp: fix crash with mptcp-ulp on tcp sockets

Florian Westphal posted 2 patches 2 years, 4 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20211206155120.26929-1-fw@strlen.de

Maintainers: Peter Krystad <peter.krystad@linux.intel.com>, Jakub Kicinski <kuba@kernel.org>, "David S. Miller" <davem@davemloft.net>, Florian Westphal <fw@strlen.de>, Davide Caratti <dcaratti@redhat.com>, Mat Martineau <mathew.j.martineau@linux.intel.com>, Shuah Khan <shuah@kernel.org>, Matthieu Baerts <matthieu.baerts@tessares.net>

net/mptcp/protocol.c                          |  1 +
.../selftests/net/mptcp/mptcp_connect.c       | 97 ++++++++++---------
.../selftests/net/mptcp/mptcp_connect.sh      | 20 ----
3 files changed, 52 insertions(+), 66 deletions(-)

Expand all Fold all

[PATCH mptcp 0/2] mptcp: fix crash with mptcp-ulp on tcp sockets

Posted by Florian Westphal 2 years, 4 months ago

While working on the tls-ULP syzbot report I found that its also
possible to set the "mptcp" ulp from userspace, iff the socket is a
tcp socket returned via accept() on an mptcp listen socket.

First patch fixes this, second patch adds a test case.

Florian Westphal (2):
  mptcp: clear 'kern' flag from fallback sockets
  selftests: mptcp: try to set mptcp ulp mode in different sk states

 net/mptcp/protocol.c                          |  1 +
 .../selftests/net/mptcp/mptcp_connect.c       | 97 ++++++++++---------
 .../selftests/net/mptcp/mptcp_connect.sh      | 20 ----
 3 files changed, 52 insertions(+), 66 deletions(-)

-- 
2.32.0

Re: [PATCH mptcp 0/2] mptcp: fix crash with mptcp-ulp on tcp sockets

Posted by Matthieu Baerts 2 years, 4 months ago

Hi Florian, Mat,

On 06/12/2021 16:51, Florian Westphal wrote:
> While working on the tls-ULP syzbot report I found that its also
> possible to set the "mptcp" ulp from userspace, iff the socket is a
> tcp socket returned via accept() on an mptcp listen socket.
> 
> First patch fixes this, second patch adds a test case.
>
> Florian Westphal (2):
>   mptcp: clear 'kern' flag from fallback sockets
>   selftests: mptcp: try to set mptcp ulp mode in different sk states

Thank you for the patches and the reviews!

- cf6bfb9af34f: mptcp: clear 'kern' flag from fallback sockets
 (v2)
- Results: 4be3d8d5b45c..23aff1c44f69

- 9a7f7dc671fc: selftests: mptcp: try to set mptcp ulp mode in different
sk states

- Results: 23aff1c44f69..1250e74665ba

Builds and tests are now in progress:



https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20211207T135708

https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net