[RFC PATCH 0/4] mptcp: Update netlink interface for userspace PM

Kishen Maloor posted 4 patches 2 weeks, 1 day ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/20211007043656.261552-1-kishen.maloor@intel.com
Maintainers: Matthieu Baerts <matthieu.baerts@tessares.net>, Shuah Khan <shuah@kernel.org>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Mat Martineau <mathew.j.martineau@linux.intel.com>
include/uapi/linux/mptcp.h                    |   4 +
net/mptcp/pm_netlink.c                        |  88 +++++++++
tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 172 ++++++++++++++++++
3 files changed, 264 insertions(+)

[RFC PATCH 0/4] mptcp: Update netlink interface for userspace PM

Posted by Kishen Maloor 2 weeks, 1 day ago
This patch series marks the beginning of an attempt to update the MPTCP
netlink interface with commands to support the offloading of path management 
decisions to userspace path managers.

Specifically, the commits in this series introduce the following commands:

* MPTCP_PM_CMD_ANNOUNCE: Issue an ADD_ADDR advertisement over the selected MPTCP
  connection.

* MPTCP_PM_CMD_REMOVE: Issue a REMOVE_ADDR signal to remove a previously added
  address over the selected MPTCP connection.

Additionally, the PM netlink test controller (pm_nl_ctl) was updated to
support the new commands.

The netlink implementations above exercise the "userspace PM mode" defined
in the following patch series:
https://lore.kernel.org/mptcp/20211006235953.212243-1-mathew.j.martineau@linux.intel.com/T/#t

Kishen Maloor (4):
  mptcp: pm_netlink: Add MPTCP_PM_CMD_ANNOUNCE
  mptcp: selftests: MPTCP_PM_CMD_ANNOUNCE
  mptcp: pm_netlink: Add MPTCP_PM_CMD_REMOVE
  mptcp: selftests: MPTCP_PM_CMD_REMOVE

 include/uapi/linux/mptcp.h                    |   4 +
 net/mptcp/pm_netlink.c                        |  88 +++++++++
 tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 172 ++++++++++++++++++
 3 files changed, 264 insertions(+)

-- 
2.31.1


Re: [RFC PATCH 0/4] mptcp: Update netlink interface for userspace PM

Posted by Florian Westphal 2 weeks, 1 day ago
Kishen Maloor <kishen.maloor@intel.com> wrote:
> This patch series marks the beginning of an attempt to update the MPTCP
> netlink interface with commands to support the offloading of path management 
> decisions to userspace path managers.
> 
> Specifically, the commits in this series introduce the following commands:
> 
> * MPTCP_PM_CMD_ANNOUNCE: Issue an ADD_ADDR advertisement over the selected MPTCP
>   connection.

Looks like you guys are further ahead than me.
I've pushed my work here:

iproute2:
https://git.breakpoint.cc/cgit/fw/iproute2.git/log/?h=mptcp_sf_03

kernel:
https://git.breakpoint.cc/cgit/fw/mptcp_net-next.git/log/?h=netlink_cmd_07

I had planned to work on packetdrill tests next but to avoid
further duplicate work I will refrain from doing so.

Feel free to take what you need and/or mangle and discard this at will.

Re: [RFC PATCH 0/4] mptcp: Update netlink interface for userspace PM

Posted by Paolo Abeni 2 weeks, 1 day ago
On Thu, 2021-10-07 at 10:32 +0200, Florian Westphal wrote:
> Kishen Maloor <kishen.maloor@intel.com> wrote:
> > This patch series marks the beginning of an attempt to update the MPTCP
> > netlink interface with commands to support the offloading of path management 
> > decisions to userspace path managers.
> > 
> > Specifically, the commits in this series introduce the following commands:
> > 
> > * MPTCP_PM_CMD_ANNOUNCE: Issue an ADD_ADDR advertisement over the selected MPTCP
> >   connection.
> 
> Looks like you guys are further ahead than me.
> I've pushed my work here:
> 
> iproute2:
> https://git.breakpoint.cc/cgit/fw/iproute2.git/log/?h=mptcp_sf_03
> 
> kernel:
> https://git.breakpoint.cc/cgit/fw/mptcp_net-next.git/log/?h=netlink_cmd_07
> 
> I had planned to work on packetdrill tests next but to avoid
> further duplicate work I will refrain from doing so.
> 
> Feel free to take what you need and/or mangle and discard this at will.

It looks like your patch:

mptcp: netlink: allow userspace-driven subflow establishment

implements feature not available here, while:

mptcp: netlink: allow userspace to perform address announcements

overlaps with this effort.

I think we can merge the 2 series into a single one dropping only the
later patch, if there is agreement.

Cheers,

Paolo


Re: [RFC PATCH 0/4] mptcp: Update netlink interface for userspace PM

Posted by Kishen Maloor 2 weeks ago
On 10/7/21 4:26 AM, Paolo Abeni wrote:
> On Thu, 2021-10-07 at 10:32 +0200, Florian Westphal wrote:
>> Kishen Maloor <kishen.maloor@intel.com> wrote:
>>> This patch series marks the beginning of an attempt to update the MPTCP
>>> netlink interface with commands to support the offloading of path management 
>>> decisions to userspace path managers.
>>>
>>> Specifically, the commits in this series introduce the following commands:
>>>
>>> * MPTCP_PM_CMD_ANNOUNCE: Issue an ADD_ADDR advertisement over the selected MPTCP
>>>   connection.
>>
>> Looks like you guys are further ahead than me.
>> I've pushed my work here:
>>
>> iproute2:
>> https://git.breakpoint.cc/cgit/fw/iproute2.git/log/?h=mptcp_sf_03
>>
>> kernel:
>> https://git.breakpoint.cc/cgit/fw/mptcp_net-next.git/log/?h=netlink_cmd_07
>>

Thank you. Just so its clear, I'd picked up this Github issue assigned to Mat mostly to avoid such overlap :)

>> I had planned to work on packetdrill tests next but to avoid
>> further duplicate work I will refrain from doing so.

I can say that you won't see any duplication here specifically :)

>>
>> Feel free to take what you need and/or mangle and discard this at will.
> 
> It looks like your patch:
> 
> mptcp: netlink: allow userspace-driven subflow establishment
> 
> implements feature not available here, while:
> 
> mptcp: netlink: allow userspace to perform address announcements
> 
> overlaps with this effort.
> 
> I think we can merge the 2 series into a single one dropping only the
> later patch, if there is agreement.

Yup, we can look into this.

> 
> Cheers,
> 
> Paolo
>