Squash to "mptcp: don't return sockets in foreign netns"

[PATCH mptcp-next] Squash to "mptcp: don't return sockets in foreign netns"

Matthieu Baerts posted 1 patch 4 years ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/dcaratti/mptcp_net-next tags/patchew/20210918080539.2051616-1-matthieu.baerts@tessares.net

Maintainers: "David S. Miller" <davem@davemloft.net>, Mat Martineau <mathew.j.martineau@linux.intel.com>, Matthieu Baerts <matthieu.baerts@tessares.net>, Jakub Kicinski <kuba@kernel.org>

net/mptcp/token.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH mptcp-next] Squash to "mptcp: don't return sockets in foreign netns"

Posted by Matthieu Baerts 4 years ago

Add missing doc for the new 'net' parameter.

'make W=1' returned this warning:

  net/mptcp/token.c:242: warning: Function parameter or member 'net' not described in 'mptcp_token_get_sock'

This caused the failure reported by Github Action job:

  https://github.com/multipath-tcp/mptcp_net-next/runs/3623640967?check_suite_focus=true

Cc: Florian Westphal <fw@strlen.de>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
---

Notes:
    to be squashed in "mptcp: don't return sockets in foreign netns"

 net/mptcp/token.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/mptcp/token.c b/net/mptcp/token.c
index 313a3e793e61..e581b341c5be 100644
--- a/net/mptcp/token.c
+++ b/net/mptcp/token.c
@@ -231,6 +231,7 @@ bool mptcp_token_exists(u32 token)
 
 /**
  * mptcp_token_get_sock - retrieve mptcp connection sock using its token
+ * @net: restrict to this namespace
  * @token: token of the mptcp connection to retrieve
  *
  * This function returns the mptcp connection structure with the given token.
-- 
2.32.0

Re: [PATCH mptcp-next] Squash to "mptcp: don't return sockets in foreign netns"

Posted by Matthieu Baerts 3 years, 12 months ago

Hi Florian,

On 18/09/2021 10:05, Matthieu Baerts wrote:
> Add missing doc for the new 'net' parameter.
> 
> 'make W=1' returned this warning:
> 
>   net/mptcp/token.c:242: warning: Function parameter or member 'net' not described in 'mptcp_token_get_sock'

Thank you for the review! Now in our tree:

- 91017a33fdaf: "squashed" in "mptcp: don't return sockets in foreign netns"
- Without co-dev tags for just that
- Results: 9362f2920995..3d2c77807730

Builds are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20210919T070621

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net