Squash to "selftests/bpf: Add bpf_burst scheduler"

[PATCH mptcp-next] Squash to "selftests/bpf: Add bpf_burst scheduler"

Geliang Tang posted 1 patch 5 months, 3 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/14a1120c9bc792ead2b926208ce85b5f10cb99fd.1700624540.git.geliang.tang@suse.com

Maintainers: Andrii Nakryiko <andrii@kernel.org>, Mykola Lysenko <mykolal@fb.com>, Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, Martin KaFai Lau <martin.lau@linux.dev>, Song Liu <song@kernel.org>, Yonghong Song <yonghong.song@linux.dev>, John Fastabend <john.fastabend@gmail.com>, KP Singh <kpsingh@kernel.org>, Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>

tools/testing/selftests/bpf/bpf_tcp_helpers.h | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH mptcp-next] Squash to "selftests/bpf: Add bpf_burst scheduler"

Posted by Geliang Tang 5 months, 3 weeks ago

Fix the bpf selftests build error:

progs/mptcp_bpf_burst.c:37:18: error: no member named 'write_seq' in 'struct tcp_sock'
        return tp ? tp->write_seq == tp->snd_nxt : true;
                    ~~  ^
1 error generated.
make: *** [Makefile:614: tools/testing/selftests/bpf/mptcp_bpf_burst.bpf.o] Error 1
make: *** Waiting for unfinished jobs....

Reported-by: kernel test robot <yujie.liu@intel.com>
Closes: https://lore.kernel.org/r/202311180438.KHYloYBe-lkp@intel.com/
Signed-off-by: Geliang Tang <geliang.tang@suse.com>
---
 tools/testing/selftests/bpf/bpf_tcp_helpers.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/bpf/bpf_tcp_helpers.h b/tools/testing/selftests/bpf/bpf_tcp_helpers.h
index 6b43845f1234..2c71226b3631 100644
--- a/tools/testing/selftests/bpf/bpf_tcp_helpers.h
+++ b/tools/testing/selftests/bpf/bpf_tcp_helpers.h
@@ -87,6 +87,7 @@ struct tcp_sock {
 	__u32	lsndtime;
 	__u32	prior_cwnd;
 	__u64	tcp_mstamp;	/* most recent packet received/sent */
+	__u32	write_seq;	/* Tail(+1) of data held in tcp send buffer */
 	bool	is_mptcp;
 } __attribute__((preserve_access_index));
 
-- 
2.35.3

Re: [PATCH mptcp-next] Squash to "selftests/bpf: Add bpf_burst scheduler"

Posted by Matthieu Baerts 5 months, 3 weeks ago

Hi Geliang,

On 22/11/2023 04:42, Geliang Tang wrote:
> Fix the bpf selftests build error:
> 
> progs/mptcp_bpf_burst.c:37:18: error: no member named 'write_seq' in 'struct tcp_sock'
>         return tp ? tp->write_seq == tp->snd_nxt : true;
>                     ~~  ^
> 1 error generated.
> make: *** [Makefile:614: tools/testing/selftests/bpf/mptcp_bpf_burst.bpf.o] Error 1
> make: *** Waiting for unfinished jobs....

Thank you for the patch, now in our tree:

New patches for t/upstream:
- bd37dad396df: "squashed" in "selftests/bpf: Add bpf_burst scheduler"
- Results: d4787f01696d..1ee636354037 (export)

Tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20231127T175348

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.