qemu: fix memory leak in qemuBuildDiskDeviceStr

[libvirt] [PATCH] qemu: fix memory leak in qemuBuildDiskDeviceStr

Ján Tomko posted 1 patch 5 years, 2 months ago

Download mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/f9853162ff5269128092768d08794a47e6ac223f.1550762887.git.jtomko@redhat.com

src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] qemu: fix memory leak in qemuBuildDiskDeviceStr

Posted by Ján Tomko 5 years, 2 months ago

Commit a1dce962 added the allocated scsiVPDDeviceId without freeing it.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/qemu/qemu_command.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index f511193fca..74f34af292 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -1890,7 +1890,7 @@ qemuBuildDiskDeviceStr(const virDomainDef *def,
     const char *bus = virDomainDiskQEMUBusTypeToString(disk->bus);
     const char *contAlias;
     char *backendAlias = NULL;
-    char *scsiVPDDeviceId = NULL;
+    VIR_AUTOFREE(char *) scsiVPDDeviceId = NULL;
     int controllerModel;
 
     if (qemuCheckDiskConfig(disk, qemuCaps) < 0)
-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: fix memory leak in qemuBuildDiskDeviceStr

Posted by Peter Krempa 5 years, 2 months ago

On Thu, Feb 21, 2019 at 16:28:10 +0100, Ján Tomko wrote:
> Commit a1dce962 added the allocated scsiVPDDeviceId without freeing it.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/qemu/qemu_command.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list