[PATCH] Revert ".gitignore: Ignore cscope and other *tags files"

Martin Kletzander posted 1 patch 1 year, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/f53f5bdfea30e6984d823233e7cee0ec3b784c1e.1675693709.git.mkletzan@redhat.com
There is a newer version of this series
.gitignore | 11 -----------
1 file changed, 11 deletions(-)
[PATCH] Revert ".gitignore: Ignore cscope and other *tags files"
Posted by Martin Kletzander 1 year, 2 months ago
This reverts commit f2d379e7cb802f922409c35e4831ee52a2162486.  On top of that it
also removes the `/tags` file because we don't even have the `make tags` target
any more.  Any tool-related ignores should go to user's global ignore file or
the user's local exclude file which is per-project.  See git-config(1) and
gitignore(5) for more details.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
 .gitignore | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/.gitignore b/.gitignore
index 61ea7779b02b..0898c0d29f3c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -20,17 +20,6 @@ __pycache__/
 /build/
 /ci/scratch/
 
-# *tags and cscope files
-/GPATH
-/GRTAGS
-/GTAGS
-/TAGS
-/cscope.files
-/cscope.in.out
-/cscope.out
-/cscope.po.out
-/tags
-
 # clangd related ignores
 .clangd
 compile_commands.json
-- 
2.39.1
Re: [PATCH] Revert ".gitignore: Ignore cscope and other *tags files"
Posted by Peter Krempa 1 year, 2 months ago
On Mon, Feb 06, 2023 at 15:28:29 +0100, Martin Kletzander wrote:
> This reverts commit f2d379e7cb802f922409c35e4831ee52a2162486.  On top of that it
> also removes the `/tags` file because we don't even have the `make tags` target
> any more.  Any tool-related ignores should go to user's global ignore file or
> the user's local exclude file which is per-project.  See git-config(1) and
> gitignore(5) for more details.

We still carry '.ctags'. With that directory you don't need any fancy
'make tags' because simply running 'ctags' in the source code directory
just does the right thing.
Re: [PATCH] Revert ".gitignore: Ignore cscope and other *tags files"
Posted by Martin Kletzander 1 year, 2 months ago
On Mon, Feb 06, 2023 at 03:32:20PM +0100, Peter Krempa wrote:
>On Mon, Feb 06, 2023 at 15:28:29 +0100, Martin Kletzander wrote:
>> This reverts commit f2d379e7cb802f922409c35e4831ee52a2162486.  On top of that it
>> also removes the `/tags` file because we don't even have the `make tags` target
>> any more.  Any tool-related ignores should go to user's global ignore file or
>> the user's local exclude file which is per-project.  See git-config(1) and
>> gitignore(5) for more details.
>
>We still carry '.ctags'. With that directory you don't need any fancy
>'make tags' because simply running 'ctags' in the source code directory
>just does the right thing.
>

So /tags it's not needed in the .gitignore either.
Re: [PATCH] Revert ".gitignore: Ignore cscope and other *tags files"
Posted by Peter Krempa 1 year, 2 months ago
On Mon, Feb 06, 2023 at 15:38:11 +0100, Martin Kletzander wrote:
> On Mon, Feb 06, 2023 at 03:32:20PM +0100, Peter Krempa wrote:
> > On Mon, Feb 06, 2023 at 15:28:29 +0100, Martin Kletzander wrote:
> > > This reverts commit f2d379e7cb802f922409c35e4831ee52a2162486.  On top of that it
> > > also removes the `/tags` file because we don't even have the `make tags` target
> > > any more.  Any tool-related ignores should go to user's global ignore file or
> > > the user's local exclude file which is per-project.  See git-config(1) and
> > > gitignore(5) for more details.
> > 
> > We still carry '.ctags'. With that directory you don't need any fancy
> > 'make tags' because simply running 'ctags' in the source code directory
> > just does the right thing.
> > 
> 
> So /tags it's not needed in the .gitignore either.

I don't quite follow why. Running 'ctags' with the configuration we have
in the repository creates an untracked 'tags' file which we don't want
to commit/distribute.
Re: [PATCH] Revert ".gitignore: Ignore cscope and other *tags files"
Posted by Martin Kletzander 1 year, 2 months ago
On Mon, Feb 06, 2023 at 03:40:44PM +0100, Peter Krempa wrote:
>On Mon, Feb 06, 2023 at 15:38:11 +0100, Martin Kletzander wrote:
>> On Mon, Feb 06, 2023 at 03:32:20PM +0100, Peter Krempa wrote:
>> > On Mon, Feb 06, 2023 at 15:28:29 +0100, Martin Kletzander wrote:
>> > > This reverts commit f2d379e7cb802f922409c35e4831ee52a2162486.  On top of that it
>> > > also removes the `/tags` file because we don't even have the `make tags` target
>> > > any more.  Any tool-related ignores should go to user's global ignore file or
>> > > the user's local exclude file which is per-project.  See git-config(1) and
>> > > gitignore(5) for more details.
>> >
>> > We still carry '.ctags'. With that directory you don't need any fancy
>> > 'make tags' because simply running 'ctags' in the source code directory
>> > just does the right thing.
>> >
>>
>> So /tags it's not needed in the .gitignore either.
>
>I don't quite follow why. Running 'ctags' with the configuration we have
>in the repository creates an untracked 'tags' file which we don't want
>to commit/distribute.
>

Oh, and that creates the tags file, I misunderstood the first comment
then, I'll remove the removal of /tags from the commit then.