Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

Rebased version of the patch sent earlier, because the file was changed
meanwhile.

 NEWS.rst | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/NEWS.rst b/NEWS.rst
index 7ced82e3da..554ca559a2 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -22,6 +22,13 @@ v10.3.0 (unreleased)
     USB address is now automatically assigned to USB network devices thus they
     can be used without manual configuration.
 
+  * conf: Introduce memReserve to <controller/>
+
+    Some PCI devices have large non-prefetchable memory. This is not a problem
+    for coldplug because firmware sets up such devices properly. But it may be
+    a problem for hotplug devices. To resolve this, new ``memReserve``
+    attribute is introduced which allows overriding value computed by firmware.
+
 * **Improvements**
 
   * Improve validation of USB devices
@@ -35,6 +42,11 @@ v10.3.0 (unreleased)
     The ``checkpoint-list`` and ``snapshot-list`` commands would ignore the
     ``--name`` option to print only the name when used with ``--parent``.
 
+  * Extend libvirt-guests to shutdown only persistent VMs
+
+    Users can now chose to shutdown only persistent VMs when the host is being
+    shut down.
+
 * **Bug fixes**
 
   * qemu: Fix migration with custom XML
@@ -54,6 +66,16 @@ v10.3.0 (unreleased)
 
      error: internal error: unable to execute QEMU command 'blockdev-add': Certificate does not match the hostname
 
+  * Create OVS ports as transient
+
+    Libvirt now creates OVS ports as transient which prevents them from
+    reappearing or going stale on sudden reboots.
+
+  * Clear OVS QoS settings when domain shuts down
+
+    Libvirt now clears QoS settings on domain shutdown, so they no longer pile
+    up in OVS database.
+
 
 v10.2.0 (2024-04-02)
 ====================
-- 
2.43.2
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

On Thu, May 02, 2024 at 08:52:17 +0200, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
> 
> Rebased version of the patch sent earlier, because the file was changed
> meanwhile.
> 
>  NEWS.rst | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/NEWS.rst b/NEWS.rst
> index 7ced82e3da..554ca559a2 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -22,6 +22,13 @@ v10.3.0 (unreleased)
>      USB address is now automatically assigned to USB network devices thus they
>      can be used without manual configuration.
>  
> +  * conf: Introduce memReserve to <controller/>
> +
> +    Some PCI devices have large non-prefetchable memory. This is not a problem
> +    for coldplug because firmware sets up such devices properly. But it may be
> +    a problem for hotplug devices. To resolve this, new ``memReserve``
> +    attribute is introduced which allows overriding value computed by firmware.
> +
>  * **Improvements**
>  
>    * Improve validation of USB devices
> @@ -35,6 +42,11 @@ v10.3.0 (unreleased)
>      The ``checkpoint-list`` and ``snapshot-list`` commands would ignore the
>      ``--name`` option to print only the name when used with ``--parent``.
>  
> +  * Extend libvirt-guests to shutdown only persistent VMs
> +
> +    Users can now chose to shutdown only persistent VMs when the host is being

s/chose/choose/

> +    shut down.
> +
>  * **Bug fixes**
>  
>    * qemu: Fix migration with custom XML
> @@ -54,6 +66,16 @@ v10.3.0 (unreleased)
>  
>       error: internal error: unable to execute QEMU command 'blockdev-add': Certificate does not match the hostname
>  
> +  * Create OVS ports as transient
> +
> +    Libvirt now creates OVS ports as transient which prevents them from
> +    reappearing or going stale on sudden reboots.
> +
> +  * Clear OVS QoS settings when domain shuts down
> +
> +    Libvirt now clears QoS settings on domain shutdown, so they no longer pile
> +    up in OVS database.
> +
>  
>  v10.2.0 (2024-04-02)
>  ====================

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

On Thu, May 02, 2024 at 08:52:17 +0200, Michal Privoznik wrote:
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
> 
> Rebased version of the patch sent earlier, because the file was changed
> meanwhile.

Sorry for that. I've changed what Jirka requested and forgot to push my
patches on Tuesday :/

> 
>  NEWS.rst | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/NEWS.rst b/NEWS.rst
> index 7ced82e3da..554ca559a2 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -22,6 +22,13 @@ v10.3.0 (unreleased)
>      USB address is now automatically assigned to USB network devices thus they
>      can be used without manual configuration.
>  
> +  * conf: Introduce memReserve to <controller/>
> +
> +    Some PCI devices have large non-prefetchable memory. This is not a problem
> +    for coldplug because firmware sets up such devices properly. But it may be
> +    a problem for hotplug devices. To resolve this, new ``memReserve``
> +    attribute is introduced which allows overriding value computed by firmware.

The last sentence at first glance seems to contradict the previous
statement that the firmware does stuff correctly. I don't know the
details but is really firmware the problem when hotplugging? Isn't this
more of a hint to the guest OS?

As I don't have a better suggestion:

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

On 5/2/24 09:33, Peter Krempa wrote:
> On Thu, May 02, 2024 at 08:52:17 +0200, Michal Privoznik wrote:
>> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>> ---
>>
>> Rebased version of the patch sent earlier, because the file was changed
>> meanwhile.
> 
> Sorry for that. I've changed what Jirka requested and forgot to push my
> patches on Tuesday :/
> 
>>
>>  NEWS.rst | 22 ++++++++++++++++++++++
>>  1 file changed, 22 insertions(+)
>>
>> diff --git a/NEWS.rst b/NEWS.rst
>> index 7ced82e3da..554ca559a2 100644
>> --- a/NEWS.rst
>> +++ b/NEWS.rst
>> @@ -22,6 +22,13 @@ v10.3.0 (unreleased)
>>      USB address is now automatically assigned to USB network devices thus they
>>      can be used without manual configuration.
>>  
>> +  * conf: Introduce memReserve to <controller/>
>> +
>> +    Some PCI devices have large non-prefetchable memory. This is not a problem
>> +    for coldplug because firmware sets up such devices properly. But it may be
>> +    a problem for hotplug devices. To resolve this, new ``memReserve``
>> +    attribute is introduced which allows overriding value computed by firmware.
> 
> The last sentence at first glance seems to contradict the previous
> statement that the firmware does stuff correctly. I don't know the
> details but is really firmware the problem when hotplugging? Isn't this
> more of a hint to the guest OS?

I'm no expert in that area either, but the way I understand it: during
cold boot, FW calculates some values which may be then too small during
hotplug. If the device was there from the beginning (i.e. during cold
boot) FW would handle the device correctly (i.e. compute correct
values). But since FW can't foresee the future it stays conservative.
But users can! Hence the knob.

I'll try to rephrase the last sentence (or whole paragraph).

> 
> As I don't have a better suggestion:
> 
> Reviewed-by: Peter Krempa <pkrempa@redhat.com>
> 

Thanks.

Michal
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

On Thu, May 02, 2024 at 09:41:09 +0200, Michal Prívozník wrote:
> On 5/2/24 09:33, Peter Krempa wrote:
> > On Thu, May 02, 2024 at 08:52:17 +0200, Michal Privoznik wrote:
> >> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> >> ---
> >>
> >> Rebased version of the patch sent earlier, because the file was changed
> >> meanwhile.
> > 
> > Sorry for that. I've changed what Jirka requested and forgot to push my
> > patches on Tuesday :/
> > 
> >>
> >>  NEWS.rst | 22 ++++++++++++++++++++++
> >>  1 file changed, 22 insertions(+)
> >>
> >> diff --git a/NEWS.rst b/NEWS.rst
> >> index 7ced82e3da..554ca559a2 100644
> >> --- a/NEWS.rst
> >> +++ b/NEWS.rst
> >> @@ -22,6 +22,13 @@ v10.3.0 (unreleased)
> >>      USB address is now automatically assigned to USB network devices thus they
> >>      can be used without manual configuration.
> >>  
> >> +  * conf: Introduce memReserve to <controller/>
> >> +
> >> +    Some PCI devices have large non-prefetchable memory. This is not a problem
> >> +    for coldplug because firmware sets up such devices properly. But it may be
> >> +    a problem for hotplug devices. To resolve this, new ``memReserve``
> >> +    attribute is introduced which allows overriding value computed by firmware.
> > 
> > The last sentence at first glance seems to contradict the previous
> > statement that the firmware does stuff correctly. I don't know the
> > details but is really firmware the problem when hotplugging? Isn't this
> > more of a hint to the guest OS?
> 
> I'm no expert in that area either, but the way I understand it: during
> cold boot, FW calculates some values which may be then too small during
> hotplug. If the device was there from the beginning (i.e. during cold
> boot) FW would handle the device correctly (i.e. compute correct
> values). But since FW can't foresee the future it stays conservative.
> But users can! Hence the knob.

Ah, I understand now. This is for future use when you expect to hotplug

Perhaps something along:

"This can be a problem in case when such device needs to be hotplugged
as the firmware can't forsee such situation. The user thus can override
the value calculated at start to accomodate for such devices."
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org