[libvirt PATCH] spec: Drop gettext-devel from the SPEC file

Erik Skultety posted 1 patch 3 years, 2 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/edaa6cd128a873ebcf0bd60b5c07bad6dd7a2024.1611746314.git.eskultet@redhat.com
libvirt.spec.in | 1 -
1 file changed, 1 deletion(-)
[libvirt PATCH] spec: Drop gettext-devel from the SPEC file
Posted by Erik Skultety 3 years, 2 months ago
With meson, we don't need the gettext headers anymore, meson takes care
of that and we only need to have xgettext installed.
Without this patch RPM build in Fedora containers fails.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---
 libvirt.spec.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 0478139305..07c7e80c4e 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -253,7 +253,6 @@ Requires: libvirt-libs = %{version}-%{release}
 
 # All build-time requirements. Run-time requirements are
 # listed against each sub-RPM
-BuildRequires: gettext-devel
 %if 0%{?rhel} == 7
 BuildRequires: python36-docutils
 %else
-- 
2.29.2

Re: [libvirt PATCH] spec: Drop gettext-devel from the SPEC file
Posted by Daniel P. Berrangé 3 years, 2 months ago
On Wed, Jan 27, 2021 at 12:18:50PM +0100, Erik Skultety wrote:
> With meson, we don't need the gettext headers anymore, meson takes care
> of that and we only need to have xgettext installed.
> Without this patch RPM build in Fedora containers fails.
> 
> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> ---
>  libvirt.spec.in | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|