[PATCH] conf: Drop unused declaration

Adam Julis posted 1 patch 2 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/ebbfcee1b7f3be0eb09529f404e2b6391abdcf56.1718794041.git.ajulis@redhat.com
src/conf/domain_conf.h | 4 ----
1 file changed, 4 deletions(-)
[PATCH] conf: Drop unused declaration
Posted by Adam Julis 2 months, 2 weeks ago
Remove unused declaration of the virDomainDiskFindByBusAndDst().

Signed-off-by: Adam Julis <ajulis@redhat.com>
---
 src/conf/domain_conf.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index a06f015444..cdab6ef2da 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -3558,10 +3558,6 @@ void virDomainDiskSetFormat(virDomainDiskDef *def, int format);
 virDomainControllerDef *
 virDomainDeviceFindSCSIController(const virDomainDef *def,
                                   const virDomainDeviceDriveAddress *addr);
-virDomainDiskDef *virDomainDiskFindByBusAndDst(virDomainDef *def,
-                                               int bus,
-                                               char *dst);
-
 virDomainControllerDef *virDomainControllerDefNew(virDomainControllerType type);
 void virDomainControllerDefFree(virDomainControllerDef *def);
 G_DEFINE_AUTOPTR_CLEANUP_FUNC(virDomainControllerDef, virDomainControllerDefFree);
-- 
2.45.0
Re: [PATCH] conf: Drop unused declaration
Posted by Michal Prívozník 2 months, 2 weeks ago
On 6/19/24 12:48, Adam Julis wrote:
> Remove unused declaration of the virDomainDiskFindByBusAndDst().
> 
> Signed-off-by: Adam Julis <ajulis@redhat.com>
> ---
>  src/conf/domain_conf.h | 4 ----
>  1 file changed, 4 deletions(-)

Nice catch!

I've tweaked the commit message a bit to point out how did we get here.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal