qemu: Fix indentation in virDomainDefFormatInternal

[libvirt] [PATCH] qemu: Fix indentation in virDomainDefFormatInternal

Jiri Denemark posted 1 patch 5 years, 7 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/e835ea7a1ddc76ead7c1b40b832a0cdd63f25a6e.1536248688.git.jdenemar@redhat.com

Test syntax-check passed

src/conf/domain_conf.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

Expand all Fold all

[libvirt] [PATCH] qemu: Fix indentation in virDomainDefFormatInternal

Posted by Jiri Denemark 5 years, 7 months ago

Broken by v3.10.0-68-gaed3d038a6.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 src/conf/domain_conf.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 86199623cc..6aa5ff51b4 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -27582,10 +27582,10 @@ virDomainDefFormatInternal(virDomainDefPtr def,
          * but no leading indentation before the starting element.
          * Thankfully, libxml maps what looks like globals into
          * thread-local uses, so we are thread-safe.  */
-            xmlIndentTreeOutput = 1;
-            xmlbuf = xmlBufferCreate();
-            if (xmlNodeDump(xmlbuf, def->metadata->doc, def->metadata,
-                            virBufferGetIndent(buf, false) / 2, 1) < 0) {
+        xmlIndentTreeOutput = 1;
+        xmlbuf = xmlBufferCreate();
+        if (xmlNodeDump(xmlbuf, def->metadata->doc, def->metadata,
+                        virBufferGetIndent(buf, false) / 2, 1) < 0) {
             xmlBufferFree(xmlbuf);
             xmlIndentTreeOutput = oldIndentTreeOutput;
             goto error;
-- 
2.18.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: Fix indentation in virDomainDefFormatInternal

Posted by John Ferlan 5 years, 7 months ago


On 09/06/2018 11:44 AM, Jiri Denemark wrote:
> Broken by v3.10.0-68-gaed3d038a6.
> 
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> ---
>  src/conf/domain_conf.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

Trivial.

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list