qemu: monitor: No need to debug-log the 'mon' pointer

[libvirt] [PATCH] qemu: monitor: No need to debug-log the 'mon' pointer

Peter Krempa posted 1 patch 7 years ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/e72b544a098f7a2698293c4eb07651160646574b.1491394908.git.pkrempa@redhat.com

src/qemu/qemu_monitor.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)

Expand all Fold all

[libvirt] [PATCH] qemu: monitor: No need to debug-log the 'mon' pointer

Posted by Peter Krempa 7 years ago

QEMU_CHECK_MONITOR_* already logs the object and vm name
---
 src/qemu/qemu_monitor.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index a4fa6eca6..2fc6192dc 100644
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
@@ -4194,8 +4194,6 @@ qemuMonitorMigrateIncoming(qemuMonitorPtr mon,
 int
 qemuMonitorMigrateStartPostCopy(qemuMonitorPtr mon)
 {
-    VIR_DEBUG("mon=%p", mon);
-
     QEMU_CHECK_MONITOR_JSON(mon);

     return qemuMonitorJSONMigrateStartPostCopy(mon);
@@ -4205,8 +4203,6 @@ int
 qemuMonitorGetRTCTime(qemuMonitorPtr mon,
                       struct tm *tm)
 {
-    VIR_DEBUG("mon=%p", mon);
-
     QEMU_CHECK_MONITOR_JSON(mon);

     return qemuMonitorJSONGetRTCTime(mon, tm);
@@ -4216,8 +4212,6 @@ qemuMonitorGetRTCTime(qemuMonitorPtr mon,
 virHashTablePtr
 qemuMonitorQueryQMPSchema(qemuMonitorPtr mon)
 {
-    VIR_DEBUG("mon=%p", mon);
-
     QEMU_CHECK_MONITOR_JSON_NULL(mon);

     return qemuMonitorJSONQueryQMPSchema(mon);
@@ -4229,7 +4223,7 @@ qemuMonitorSetBlockThreshold(qemuMonitorPtr mon,
                              const char *nodename,
                              unsigned long long threshold)
 {
-    VIR_DEBUG("mon=%p, node='%s', threshold=%llu", mon, nodename, threshold);
+    VIR_DEBUG("node='%s', threshold=%llu", nodename, threshold);

     QEMU_CHECK_MONITOR_JSON(mon);

@@ -4240,8 +4234,6 @@ qemuMonitorSetBlockThreshold(qemuMonitorPtr mon,
 virJSONValuePtr
 qemuMonitorQueryNamedBlockNodes(qemuMonitorPtr mon)
 {
-    VIR_DEBUG("mon=%p", mon);
-
     QEMU_CHECK_MONITOR_JSON_NULL(mon);

     return qemuMonitorJSONQueryNamedBlockNodes(mon);
-- 
2.12.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: monitor: No need to debug-log the 'mon' pointer

Posted by Ján Tomko 7 years ago

On Wed, Apr 05, 2017 at 02:21:48PM +0200, Peter Krempa wrote:
>QEMU_CHECK_MONITOR_* already logs the object and vm name
>---
> src/qemu/qemu_monitor.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>

ACK

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list