qemu_driver: Fix order of arguments in qemuDomainGetStatsCpuProc()

[PATCH] qemu_driver: Fix order of arguments in qemuDomainGetStatsCpuProc()

Michal Privoznik posted 1 patch 1 year, 8 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/e4f577b25ef30d4bde661dd6935559486167681a.1662478057.git.mprivozn@redhat.com

src/qemu/qemu_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH] qemu_driver: Fix order of arguments in qemuDomainGetStatsCpuProc()

Posted by Michal Privoznik 1 year, 8 months ago

Just before pushing my earlier commit I've switch order of two
arguments of virProcessGetStatInfo() (as suggested in review).
However, I forgot to swap the arguments in
qemuDomainGetStatsCpuProc() which leads to userTime and sysTime
being swapped.

Fixes: 044b8744d65f8571038f85685b3c4b241162977b
Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

Pushed as trivial.

 src/qemu/qemu_driver.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index c7cca64001..a3f8d8baf5 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -17771,10 +17771,10 @@ qemuDomainGetStatsCpuProc(virDomainObj *vm,
                           virTypedParamList *params)
 {
     unsigned long long cpuTime = 0;
-    unsigned long long sysTime = 0;
     unsigned long long userTime = 0;
+    unsigned long long sysTime = 0;
 
-    if (virProcessGetStatInfo(&cpuTime, &sysTime, &userTime,
+    if (virProcessGetStatInfo(&cpuTime, &userTime, &sysTime,
                               NULL, NULL, vm->pid, 0) < 0) {
         /* ignore error */
         return 0;
-- 
2.35.1