[libvirt] [PATCH 1.5/2] virt-driver-qemu.m4: Make qemu driver optional

Michal Privoznik posted 1 patch 4 days ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/df93ee84c5a99071b2574d0b3e869b51fb2b826b.1552566957.git.mprivozn@redhat.com
m4/virt-driver-qemu.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

[libvirt] [PATCH 1.5/2] virt-driver-qemu.m4: Make qemu driver optional

Posted by Michal Privoznik 4 days ago
The basic idea of our configure script is to probe for things
rather than have them enabled by default. This is even more
visible in the next commit where configure fails if qemu driver
is enabled but no yajl is found.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 m4/virt-driver-qemu.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/m4/virt-driver-qemu.m4 b/m4/virt-driver-qemu.m4
index 80e1d3ad46..2912b3c462 100644
--- a/m4/virt-driver-qemu.m4
+++ b/m4/virt-driver-qemu.m4
@@ -18,7 +18,7 @@ dnl <http://www.gnu.org/licenses/>.
 dnl
 
 AC_DEFUN([LIBVIRT_DRIVER_ARG_QEMU], [
-  LIBVIRT_ARG_WITH_FEATURE([QEMU], [QEMU/KVM], [yes])
+  LIBVIRT_ARG_WITH_FEATURE([QEMU], [QEMU/KVM], [check])
   LIBVIRT_ARG_WITH([QEMU_USER], [username to run QEMU system instance as],
                    ['platform dependent'])
   LIBVIRT_ARG_WITH([QEMU_GROUP], [groupname to run QEMU system instance as],
-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 1.5/2] virt-driver-qemu.m4: Make qemu driver optional

Posted by Jiri Denemark 4 days ago
On Thu, Mar 14, 2019 at 13:36:26 +0100, Michal Privoznik wrote:
> The basic idea of our configure script is to probe for things
> rather than have them enabled by default. This is even more
> visible in the next commit where configure fails if qemu driver
> is enabled but no yajl is found.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  m4/virt-driver-qemu.m4 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/m4/virt-driver-qemu.m4 b/m4/virt-driver-qemu.m4
> index 80e1d3ad46..2912b3c462 100644
> --- a/m4/virt-driver-qemu.m4
> +++ b/m4/virt-driver-qemu.m4
> @@ -18,7 +18,7 @@ dnl <http://www.gnu.org/licenses/>.
>  dnl
>  
>  AC_DEFUN([LIBVIRT_DRIVER_ARG_QEMU], [
> -  LIBVIRT_ARG_WITH_FEATURE([QEMU], [QEMU/KVM], [yes])
> +  LIBVIRT_ARG_WITH_FEATURE([QEMU], [QEMU/KVM], [check])
>    LIBVIRT_ARG_WITH([QEMU_USER], [username to run QEMU system instance as],
>                     ['platform dependent'])
>    LIBVIRT_ARG_WITH([QEMU_GROUP], [groupname to run QEMU system instance as],

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list