Revert "qemu: forbid migration with an IOMMU device"

[libvirt] [PATCH] Revert "qemu: forbid migration with an IOMMU device"

Posted by Ján Tomko 8 years, 10 months ago

This reverts commit b7118623ad5a8e6ea75d693881c08873eefa3e28.

Migration was implemented by QEMU commit:
commit 8cdcf3c1e58d04b6811956d7608efeb66c42d719
Author: Peter Xu <peterx@redhat.com>
Date:   Fri Jan 6 12:06:13 2017 +0800

    intel_iommu: allow migration

https://bugzilla.redhat.com/show_bug.cgi?id=1433994
---
 src/qemu/qemu_migration.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 15ed830..f5711bc 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -2359,12 +2359,6 @@ qemuMigrationIsAllowed(virQEMUDriverPtr driver,
                            _("migration with shmem device is not supported"));
             return false;
         }
-
-        if (vm->def->iommu) {
-            virReportError(VIR_ERR_OPERATION_INVALID, "%s",
-                           _("migration with iommu device is not supported"));
-            return false;
-        }
     }
 
     return true;
-- 
2.10.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Revert "qemu: forbid migration with an IOMMU device"

Posted by Peter Krempa 8 years, 10 months ago

On Fri, Mar 24, 2017 at 12:53:43 +0100, Ján Tomko wrote:
> This reverts commit b7118623ad5a8e6ea75d693881c08873eefa3e28.
> 
> Migration was implemented by QEMU commit:
> commit 8cdcf3c1e58d04b6811956d7608efeb66c42d719
> Author: Peter Xu <peterx@redhat.com>
> Date:   Fri Jan 6 12:06:13 2017 +0800
> 
>     intel_iommu: allow migration
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1433994
> ---
>  src/qemu/qemu_migration.c | 6 ------
>  1 file changed, 6 deletions(-)

lol, ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Revert "qemu: forbid migration with an IOMMU device"

Posted by Ján Tomko 8 years, 10 months ago

On Fri, Mar 24, 2017 at 01:06:23PM +0100, Peter Krempa wrote:
>On Fri, Mar 24, 2017 at 12:53:43 +0100, Ján Tomko wrote:
>> This reverts commit b7118623ad5a8e6ea75d693881c08873eefa3e28.
>>
>> Migration was implemented by QEMU commit:
>> commit 8cdcf3c1e58d04b6811956d7608efeb66c42d719
>> Author: Peter Xu <peterx@redhat.com>
>> Date:   Fri Jan 6 12:06:13 2017 +0800
>>
>>     intel_iommu: allow migration
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1433994
>> ---
>>  src/qemu/qemu_migration.c | 6 ------
>>  1 file changed, 6 deletions(-)
>
>lol, ACK

Pushed now, ROFL.

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list