[libvirt] [PATCH v3] qemu.conf: Make nvram list obsolete

Michal Privoznik posted 1 patch 10 weeks ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/d47ff04fd8785c4293ef86834f0f1377397a05bd.1556789460.git.mprivozn@redhat.com
src/qemu/qemu.conf | 8 ++++++++
1 file changed, 8 insertions(+)

[libvirt] [PATCH v3] qemu.conf: Make nvram list obsolete

Posted by Michal Privoznik 10 weeks ago
Now that libvirt has firmware auto selection feature the nvram
config knob is more or less obsolete. It still makes sense in
cases where distro users are using does not provide FW descriptor
files, therefore I'm not removing it.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/qemu/qemu.conf | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf
index 334b4cd4ee..5a85789d81 100644
--- a/src/qemu/qemu.conf
+++ b/src/qemu/qemu.conf
@@ -740,6 +740,14 @@
 
 # Location of master nvram file
 #
+# This configuration option is obsolete. Libvirt will follow the
+# QEMU firmware metadata specification to automatically locate
+# firmware images. See docs/interop/firmware.json in the QEMU
+# source tree. These metadata files are distributed alongside any
+# firmware images intended for use with QEMU.
+#
+# ------------------------------------------
+#
 # When a domain is configured to use UEFI instead of standard
 # BIOS it may use a separate storage for UEFI variables. If
 # that's the case libvirt creates the variable store per domain
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v3] qemu.conf: Make nvram list obsolete

Posted by Andrea Bolognani 10 weeks ago
On Thu, 2019-05-02 at 11:31 +0200, Michal Privoznik wrote:
> Now that libvirt has firmware auto selection feature the nvram
> config knob is more or less obsolete. It still makes sense in
> cases where distro users are using does not provide FW descriptor
> files, therefore I'm not removing it.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/qemu/qemu.conf | 8 ++++++++
>  1 file changed, 8 insertions(+)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

and safe for freeze.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list