1. Patchew
  2. Libvirt
  3. View series

[libvirt] [PATCH] qemu: stop qemu progress when restore failed

Jie Wang posted 1 patch 5 years, 9 months ago
Failed in applying to current master (apply log)
src/qemu/qemu_driver.c | 2 ++
1 file changed, 2 insertions(+)
[libvirt] [PATCH] qemu: stop qemu progress when restore failed
Posted by Jie Wang 5 years, 9 months ago 
>From 29482622218f525f0133be0b7db74835174035d9 Mon Sep 17 00:00:00 2001
From: Jie Wang <wangjie88@huawei.com>
Date: Thu, 5 Jul 2018 09:52:03 +0800
Subject: [PATCH] qemu: stop qemu progress when restore failed

if qemuProcessStartCPUs perform failed in qemuDomainSaveImageStartVM,
we need to stop qemu progress, otherwise will remains a wild VM
which can't be managed by libvirt.

Signed-off-by: Jie Wang <wangjie88.huawei.com>
---
 src/qemu/qemu_driver.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 9a35e04a85..639b57316d 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -6621,6 +6621,8 @@ qemuDomainSaveImageStartVM(virConnectPtr conn,
             if (virGetLastErrorCode() == VIR_ERR_OK)
                 virReportError(VIR_ERR_OPERATION_FAILED,
                                "%s", _("failed to resume domain"));
+
+            qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED, asyncJob, 0);
             goto cleanup;
         }
         if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0) {
-- 
2.15.0.windows.1




--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] Ping Re: [PATCH] qemu: stop qemu progress when restore failed
Posted by WangJie (Pluto) 5 years, 9 months ago 

On 2018/7/5 10:05, Jie Wang wrote:
>>From 29482622218f525f0133be0b7db74835174035d9 Mon Sep 17 00:00:00 2001
> From: Jie Wang <wangjie88@huawei.com>
> Date: Thu, 5 Jul 2018 09:52:03 +0800
> Subject: [PATCH] qemu: stop qemu progress when restore failed
> 
> if qemuProcessStartCPUs perform failed in qemuDomainSaveImageStartVM,
> we need to stop qemu progress, otherwise will remains a wild VM
> which can't be managed by libvirt.
> 
> Signed-off-by: Jie Wang <wangjie88.huawei.com>
> ---
>  src/qemu/qemu_driver.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 9a35e04a85..639b57316d 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -6621,6 +6621,8 @@ qemuDomainSaveImageStartVM(virConnectPtr conn,
>              if (virGetLastErrorCode() == VIR_ERR_OK)
>                  virReportError(VIR_ERR_OPERATION_FAILED,
>                                 "%s", _("failed to resume domain"));
> +
> +            qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED, asyncJob, 0);
>              goto cleanup;
>          }
>          if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0) {
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] Ping? Re: [PATCH] qemu: stop qemu progress when restore failed
Posted by WangJie (Pluto) 5 years, 9 months ago 
ping...

On 2018/7/5 10:05, Jie Wang wrote:
>>From 29482622218f525f0133be0b7db74835174035d9 Mon Sep 17 00:00:00 2001
> From: Jie Wang <wangjie88@huawei.com>
> Date: Thu, 5 Jul 2018 09:52:03 +0800
> Subject: [PATCH] qemu: stop qemu progress when restore failed
> 
> if qemuProcessStartCPUs perform failed in qemuDomainSaveImageStartVM,
> we need to stop qemu progress, otherwise will remains a wild VM
> which can't be managed by libvirt.
> 
> Signed-off-by: Jie Wang <wangjie88.huawei.com>
> ---
>  src/qemu/qemu_driver.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 9a35e04a85..639b57316d 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -6621,6 +6621,8 @@ qemuDomainSaveImageStartVM(virConnectPtr conn,
>              if (virGetLastErrorCode() == VIR_ERR_OK)
>                  virReportError(VIR_ERR_OPERATION_FAILED,
>                                 "%s", _("failed to resume domain"));
> +
> +            qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED, asyncJob, 0);
>              goto cleanup;
>          }
>          if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0) {
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Ping? Re: [PATCH] qemu: stop qemu progress when restore failed
Posted by Peter Krempa 5 years, 9 months ago 
On Mon, Jul 09, 2018 at 16:39:53 +0800, WangJie (Pluto) wrote:
> ping...

Please don't be impatient. Pinging patches after one day is kind of rude
to the reviewers. Not getting a review after 1 day does not mean we
ignored that patch. The same applies for the weekend. People don't
usually work over the weekend. Too eager pinging may actually lead to
ignoring your patches.

> 
> On 2018/7/5 10:05, Jie Wang wrote:
> >>From 29482622218f525f0133be0b7db74835174035d9 Mon Sep 17 00:00:00 2001
> > From: Jie Wang <wangjie88@huawei.com>
> > Date: Thu, 5 Jul 2018 09:52:03 +0800
> > Subject: [PATCH] qemu: stop qemu progress when restore failed
> > 
> > if qemuProcessStartCPUs perform failed in qemuDomainSaveImageStartVM,
> > we need to stop qemu progress, otherwise will remains a wild VM
> > which can't be managed by libvirt.
> > 
> > Signed-off-by: Jie Wang <wangjie88.huawei.com>
> > ---
> >  src/qemu/qemu_driver.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> > index 9a35e04a85..639b57316d 100644
> > --- a/src/qemu/qemu_driver.c
> > +++ b/src/qemu/qemu_driver.c
> > @@ -6621,6 +6621,8 @@ qemuDomainSaveImageStartVM(virConnectPtr conn,
> >              if (virGetLastErrorCode() == VIR_ERR_OK)
> >                  virReportError(VIR_ERR_OPERATION_FAILED,
> >                                 "%s", _("failed to resume domain"));
> > +
> > +            qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED, asyncJob, 0);
> >              goto cleanup;
> >          }
> >          if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0) {
> > 
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] Ping? Re: [PATCH] qemu: stop qemu progress when restore failed
Posted by WangJie (Pluto) 5 years, 9 months ago 
I feel so sorry for my impolite behavior, and waitting for your review opinions :)

On 2018/7/9 17:06, Peter Krempa wrote:
> On Mon, Jul 09, 2018 at 16:39:53 +0800, WangJie (Pluto) wrote:
>> ping...
> 
> Please don't be impatient. Pinging patches after one day is kind of rude
> to the reviewers. Not getting a review after 1 day does not mean we
> ignored that patch. The same applies for the weekend. People don't
> usually work over the weekend. Too eager pinging may actually lead to
> ignoring your patches.
> 
>>
>> On 2018/7/5 10:05, Jie Wang wrote:
>>> >From 29482622218f525f0133be0b7db74835174035d9 Mon Sep 17 00:00:00 2001
>>> From: Jie Wang <wangjie88@huawei.com>
>>> Date: Thu, 5 Jul 2018 09:52:03 +0800
>>> Subject: [PATCH] qemu: stop qemu progress when restore failed
>>>
>>> if qemuProcessStartCPUs perform failed in qemuDomainSaveImageStartVM,
>>> we need to stop qemu progress, otherwise will remains a wild VM
>>> which can't be managed by libvirt.
>>>
>>> Signed-off-by: Jie Wang <wangjie88.huawei.com>
>>> ---
>>>  src/qemu/qemu_driver.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>>> index 9a35e04a85..639b57316d 100644
>>> --- a/src/qemu/qemu_driver.c
>>> +++ b/src/qemu/qemu_driver.c
>>> @@ -6621,6 +6621,8 @@ qemuDomainSaveImageStartVM(virConnectPtr conn,
>>>              if (virGetLastErrorCode() == VIR_ERR_OK)
>>>                  virReportError(VIR_ERR_OPERATION_FAILED,
>>>                                 "%s", _("failed to resume domain"));
>>> +
>>> +            qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED, asyncJob, 0);
>>>              goto cleanup;
>>>          }
>>>          if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0) {
>>>
>>
>> --
>> libvir-list mailing list
>> libvir-list@redhat.com
>> https://www.redhat.com/mailman/listinfo/libvir-list

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] qemu: stop qemu progress when restore failed
Posted by John Ferlan 5 years, 9 months ago 

On 07/04/2018 10:05 PM, Jie Wang wrote:
>>From 29482622218f525f0133be0b7db74835174035d9 Mon Sep 17 00:00:00 2001
> From: Jie Wang <wangjie88@huawei.com>
> Date: Thu, 5 Jul 2018 09:52:03 +0800
> Subject: [PATCH] qemu: stop qemu progress when restore failed

Strange stuff in the comment message...

> 
> if qemuProcessStartCPUs perform failed in qemuDomainSaveImageStartVM,
> we need to stop qemu progress, otherwise will remains a wild VM
> which can't be managed by libvirt.

So essentially if the qemuProcessStartCPUs fails when trying to resume
after after the Restore then we have to undo the qemuProcessStart since
the VM's state will be inconsistent.

> 
> Signed-off-by: Jie Wang <wangjie88.huawei.com>
> ---
>  src/qemu/qemu_driver.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 9a35e04a85..639b57316d 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -6621,6 +6621,8 @@ qemuDomainSaveImageStartVM(virConnectPtr conn,
>              if (virGetLastErrorCode() == VIR_ERR_OK)
>                  virReportError(VIR_ERR_OPERATION_FAILED,
>                                 "%s", _("failed to resume domain"));
> +
> +            qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED, asyncJob, 0);

Don't think this is SHUTOFF_FAILED - seems to be something new perhaps
VIR_DOMAIN_SHUTOFF_RESTORE_FAILED

Hopefully a more cheery Peter will also respond with ideas ;-)...

John

>              goto cleanup;
>          }
>          if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0) {
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.